add configuration option to pass extra args to flac encode #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Add an argument to the whipper cd rip comand that can be provided on the command line or in the whipper.cd.rip section of the config file. It is retrieved inside the _ripIfNotRipped() private function, split into a list and passed down through to program/flac.py, which actually calls the flac binary. Add debug logging to that function so the actual command shows up in the debug log. Add a unittest to ensure that arguments passed to flac.encode() work as expected. Tested ripping a disc with --extra-flac-encode-args="--best -e --no-padding" from both the command line and config file as well as with the default empty value. Signed-off-by: Kevin Mitchell <kevmitch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an argument to the whipper cd rip comand that can be provided on the command line or in the whipper.cd.rip section of the config file.
It is retrieved inside the _ripIfNotRipped() private function, split into a list and passed down through to program/flac.py, which actually calls the flac binary.
Add debug logging to that function so the actual command shows up in the debug log.
Add a unittest to ensure that arguments passed to flac.encode() work as expected.
Tested ripping a disc with --extra-flac-encode-args="--best -e --no-padding" from both the command line and config file as well as with the default empty value.
Signed-off-by: Kevin Mitchell kevmitch@gmail.com