Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include full file path in log files #445

Closed
the-confessor opened this issue Jan 5, 2020 · 6 comments
Closed

Don't include full file path in log files #445

the-confessor opened this issue Jan 5, 2020 · 6 comments
Assignees
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Needed: patch A pull request is required Regression Bug that breaks functionality known to work in previous releases
Milestone

Comments

@the-confessor
Copy link

The default log file format includes the full file path to a ripped file, e.g.

Tracks:
  1:
    Filename: /media/music/Oasis - Stop the Clocks EP/Oasis - Stop the Clocks EP - 01 - Acquiesce.flac
    Peak level: 0.988617
    Pre-emphasis:

The full path to the file is really not relevant, especially given that the log file is contained in the same folder as the files.

I know that logger plugins are available but that seems like overkill for this case.

Suggestion is to just include the basename of the file:

Tracks:
  1:
    Filename: Oasis - Stop the Clocks EP - 01 - Acquiesce.flac
    Peak level: 0.988617
    Pre-emphasis:
@github-actions
Copy link

github-actions bot commented Jan 5, 2020

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing instructions.

@JoeLametta
Copy link
Collaborator

Hi, If you don't want to have the full path included in the log have you tried using the following option when ripping?

-W / --working-directory: working directory; whipper will change to this directory and files will be created relative to it when not absolute.

Example:

whipper cd rip --working-directory=/media/music/

@the-confessor
Copy link
Author

Interesting thought - I just tested with the below command and found the full file path is still captured in the log.

whipper cd rip --output-directory /tmp --working-directory /tmp

Output snippet:

Tracks:
  1:
    Filename: /tmp/Oasis - Stop the Clocks EP/Oasis - Stop the Clocks EP - 01 - Acquiesce.flac
    Peak level: 0.988617

@JoeLametta
Copy link
Collaborator

@the-confessor Have you tried specifying just the --working-directory option and see if it works that way? In case it still doesn't work I think we've found a regression...

@the-confessor
Copy link
Author

I did try that also, though I didn't capture it at the time. Result was the same.

@JoeLametta JoeLametta added Bug Generic bug: can be used together with more specific labels Regression Bug that breaks functionality known to work in previous releases Accepted Accepted issue on our roadmap Needed: patch A pull request is required labels Feb 4, 2020
@JoeLametta JoeLametta added this to the 1.0 milestone Feb 4, 2020
@JoeLametta JoeLametta self-assigned this Sep 24, 2020
@JoeLametta
Copy link
Collaborator

Hi, don't know if something has changed in the meantime but I've just tested this and it seems to work as expected:

  • If neither -O OUTPUT_DIRECTORY, --output-directory OUTPUT_DIRECTORY nor -W WORKING_DIRECTORY, --working-directory WORKING_DIRECTORY are specified, then the relative path to whipper's working directory is included in the log (following the structure defined in the templates). The rip files/folder are placed, according to the templates, under whipper's working directory.
  • If -O OUTPUT_DIRECTORY, --output-directory OUTPUT_DIRECTORY nor -W WORKING_DIRECTORY, --working-directory WORKING_DIRECTORY is specified, then the full path is included in the log (following the structure defined in the templates). The rip files/folder are placed, according to the templates, under the given path.
  • If -W WORKING_DIRECTORY, --working-directory WORKING_DIRECTORY is specified, then the relative path to the given path is included in the log (following the structure defined in the templates). The rip files/folder are placed, according to the templates, under the given path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Needed: patch A pull request is required Regression Bug that breaks functionality known to work in previous releases
Projects
None yet
Development

No branches or pull requests

2 participants