--eject=always does not work with unkown CD

[smithbone]

With eject=alwasy the CD does not eject if its unknown.
Works if the CD is ripped normally.

rsmith@engine37:~/Music/riptest$ WHIPPER_DEBUG=debug whipper --eject=always cd rip
DEBUG:whipper.common.config:loaded 2 sections from config file
DEBUG:whipper.common.config:loaded 2 sections from config file
DEBUG:whipper.common.config:loaded 2 sections from config file
DEBUG:whipper.common.config:loaded 2 sections from config file
DEBUG:whipper.common.config:loaded 2 sections from config file
DEBUG:whipper.common.config:loaded 2 sections from config file
DEBUG:whipper.common.config:looking at section u'drive:ATAPI%20%20%20%3ADVD%20A%20%20DH16ABSH%20%3AYA12'
DEBUG:whipper.common.config:vendor: 'ATAPI ' versus 'ATAPI'
DEBUG:whipper.common.config:model: 'DVD A DH16ABSH ' versus 'DVD A DH16ABSH'
DEBUG:whipper.common.config:release: 'YA12' versus 'YA12'
INFO:whipper.command.cd:using configured read offset 6
DEBUG:whipper.common.config:loaded 2 sections from config file
DEBUG:whipper.common.config:loaded 2 sections from config file
DEBUG:whipper.common.config:loaded 2 sections from config file
DEBUG:whipper.common.config:loaded 2 sections from config file
DEBUG:whipper.common.config:loaded 2 sections from config file
DEBUG:whipper.common.config:loaded 2 sections from config file
DEBUG:whipper.common.config:loaded 2 sections from config file
DEBUG:whipper.common.config:loaded 2 sections from config file
DEBUG:whipper.common.config:loaded 2 sections from config file
DEBUG:whipper.common.config:loaded 2 sections from config file
DEBUG:whipper.common.config:loaded 2 sections from config file
DEBUG:whipper.common.config:loaded 2 sections from config file
DEBUG:whipper.common.config:loaded 2 sections from config file
INFO:whipper.command.cd:checking device /dev/sr0
DEBUG:whipper.program.utils:loading (eject -t) device /dev/sr0
DEBUG:whipper.program.utils:possibly unmount real path '/dev/sr0'
DEBUG:whipper.extern.task.task:run task <whipper.program.cdrdao.ReadTOCTask object at 0x7f014d8fff50>
DEBUG:whipper.extern.task.task:Adding listener <whipper.common.task.SyncRunner object at 0x7f014d8ffe90>
DEBUG:whipper.extern.task.task:run loop
DEBUG:whipper.extern.task.task:start task <whipper.program.cdrdao.ReadTOCTask object at 0x7f014d8fff50>
DEBUG:whipper.extern.task.task:starting
DEBUG:whipper.extern.task.task:notifying progress: 0.0 on 'Reading TOC'
DEBUG:whipper.program.cdrdao:RE: Begin cdrdao toc-read
DEBUG:whipper.program.cdrdao:RE: Reached leadout
DEBUG:whipper.program.cdrdao:RE: Began reading track: 1
DEBUG:whipper.extern.task.task:notifying progress: 0.1 on 'Reading TOC'
Track 1 finished, found 19 Q sub-channels with CRC errors
DEBUG:whipper.program.cdrdao:RE: Began reading track: 2
DEBUG:whipper.extern.task.task:notifying progress: 0.2 on 'Reading TOC'
Track 2 finished, found 106 Q sub-channels with CRC errors
DEBUG:whipper.program.cdrdao:RE: Began reading track: 3
DEBUG:whipper.extern.task.task:notifying progress: 0.3 on 'Reading TOC'
Track 3 finished, found 53 Q sub-channels with CRC errors
DEBUG:whipper.program.cdrdao:RE: Began reading track: 4
DEBUG:whipper.extern.task.task:notifying progress: 0.4 on 'Reading TOC'
Track 4 finished, found 89 Q sub-channels with CRC errors
DEBUG:whipper.program.cdrdao:RE: Began reading track: 5
DEBUG:whipper.extern.task.task:notifying progress: 0.5 on 'Reading TOC'
Track 5 finished, found 91 Q sub-channels with CRC errors
DEBUG:whipper.program.cdrdao:RE: Began reading track: 6
DEBUG:whipper.extern.task.task:notifying progress: 0.6 on 'Reading TOC'
Track 6 finished, found 94 Q sub-channels with CRC errors
DEBUG:whipper.program.cdrdao:RE: Began reading track: 7
DEBUG:whipper.extern.task.task:notifying progress: 0.7 on 'Reading TOC'
Track 7 finished, found 186 Q sub-channels with CRC errors
DEBUG:whipper.program.cdrdao:RE: Began reading track: 8
DEBUG:whipper.extern.task.task:notifying progress: 0.8 on 'Reading TOC'
Track 8 finished, found 35 Q sub-channels with CRC errors
DEBUG:whipper.program.cdrdao:RE: Began reading track: 9
DEBUG:whipper.extern.task.task:notifying progress: 0.9 on 'Reading TOC'
Track 9 finished, found 73 Q sub-channels with CRC errors
DEBUG:whipper.program.cdrdao:RE: Began reading track: 10
Track 10 finished, found 77 Q sub-channels with CRC errors
DEBUG:whipper.extern.task.task:notifying progress: 1.0 on 'Reading TOC'
DEBUG:whipper.image.table:set logName
DEBUG:whipper.image.toc:found catalog number 0000000000000
DEBUG:whipper.image.toc:found track 1, mode AUDIO, at absoluteOffset 0
DEBUG:whipper.image.toc:silence of u'00:00:32'
DEBUG:whipper.image.toc:appending source, counter 0, abs offset 0, source None
DEBUG:whipper.image.toc:file data.wav, start 0, length 20400
DEBUG:whipper.image.toc:track 1, switched to new file, increased counter to 1
DEBUG:whipper.image.toc:appending source, counter 1, abs offset 32, source <File u'data.wav'>
DEBUG:whipper.image.toc:at abs offset 0, we are in source None
DEBUG:whipper.image.toc:[track 01 index 00] added <Index 00 absolute 0 path None relative 0 counter 0>
DEBUG:whipper.image.toc:at abs offset 32, we are in source <File u'data.wav'>
DEBUG:whipper.image.toc:[track 01 index 01] trackOffset 32, added <Index 01 absolute 32 path u'data.wav' relative 0 counter 1>
DEBUG:whipper.image.toc:found track 2, mode AUDIO, at absoluteOffset 20432
DEBUG:whipper.image.toc:file data.wav, start 20400, length 27976
DEBUG:whipper.image.toc:appending source, counter 1, abs offset 20432, source <File u'data.wav'>
DEBUG:whipper.image.toc:at abs offset 20432, we are in source <File u'data.wav'>
DEBUG:whipper.image.toc:[track 02 index 00] added <Index 00 absolute 20432 path u'data.wav' relative 20400 counter 1>
DEBUG:whipper.image.toc:at abs offset 20670, we are in source <File u'data.wav'>
DEBUG:whipper.image.toc:[track 02 index 01] trackOffset 238, added <Index 01 absolute 20670 path u'data.wav' relative 20638 counter 1>
DEBUG:whipper.image.toc:found track 3, mode AUDIO, at absoluteOffset 48408
DEBUG:whipper.image.toc:file data.wav, start 48376, length 21254
DEBUG:whipper.image.toc:appending source, counter 1, abs offset 48408, source <File u'data.wav'>
DEBUG:whipper.image.toc:at abs offset 48408, we are in source <File u'data.wav'>
DEBUG:whipper.image.toc:[track 03 index 00] added <Index 00 absolute 48408 path u'data.wav' relative 48376 counter 1>
DEBUG:whipper.image.toc:at abs offset 48500, we are in source <File u'data.wav'>
DEBUG:whipper.image.toc:[track 03 index 01] trackOffset 92, added <Index 01 absolute 48500 path u'data.wav' relative 48468 counter 1>
DEBUG:whipper.image.toc:found track 4, mode AUDIO, at absoluteOffset 69662
DEBUG:whipper.image.toc:file data.wav, start 69630, length 34593
DEBUG:whipper.image.toc:appending source, counter 1, abs offset 69662, source <File u'data.wav'>
DEBUG:whipper.image.toc:at abs offset 69662, we are in source <File u'data.wav'>
DEBUG:whipper.image.toc:[track 04 index 00] added <Index 00 absolute 69662 path u'data.wav' relative 69630 counter 1>
DEBUG:whipper.image.toc:at abs offset 69925, we are in source <File u'data.wav'>
DEBUG:whipper.image.toc:[track 04 index 01] trackOffset 263, added <Index 01 absolute 69925 path u'data.wav' relative 69893 counter 1>
DEBUG:whipper.image.toc:found track 5, mode AUDIO, at absoluteOffset 104255
DEBUG:whipper.image.toc:file data.wav, start 104223, length 24267
DEBUG:whipper.image.toc:appending source, counter 1, abs offset 104255, source <File u'data.wav'>
DEBUG:whipper.image.toc:at abs offset 104255, we are in source <File u'data.wav'>
DEBUG:whipper.image.toc:[track 05 index 00] added <Index 00 absolute 104255 path u'data.wav' relative 104223 counter 1>
DEBUG:whipper.image.toc:at abs offset 104497, we are in source <File u'data.wav'>
DEBUG:whipper.image.toc:[track 05 index 01] trackOffset 242, added <Index 01 absolute 104497 path u'data.wav' relative 104465 counter 1>
DEBUG:whipper.image.toc:found track 6, mode AUDIO, at absoluteOffset 128522
DEBUG:whipper.image.toc:file data.wav, start 128490, length 17120
DEBUG:whipper.image.toc:appending source, counter 1, abs offset 128522, source <File u'data.wav'>
DEBUG:whipper.image.toc:at abs offset 128522, we are in source <File u'data.wav'>
DEBUG:whipper.image.toc:[track 06 index 00] added <Index 00 absolute 128522 path u'data.wav' relative 128490 counter 1>
DEBUG:whipper.image.toc:at abs offset 128790, we are in source <File u'data.wav'>
DEBUG:whipper.image.toc:[track 06 index 01] trackOffset 268, added <Index 01 absolute 128790 path u'data.wav' relative 128758 counter 1>
DEBUG:whipper.image.toc:found track 7, mode AUDIO, at absoluteOffset 145642
DEBUG:whipper.image.toc:file data.wav, start 145610, length 21595
DEBUG:whipper.image.toc:appending source, counter 1, abs offset 145642, source <File u'data.wav'>
DEBUG:whipper.image.toc:at abs offset 145642, we are in source <File u'data.wav'>
DEBUG:whipper.image.toc:[track 07 index 00] added <Index 00 absolute 145642 path u'data.wav' relative 145610 counter 1>
DEBUG:whipper.image.toc:at abs offset 145892, we are in source <File u'data.wav'>
DEBUG:whipper.image.toc:[track 07 index 01] trackOffset 250, added <Index 01 absolute 145892 path u'data.wav' relative 145860 counter 1>
DEBUG:whipper.image.toc:found track 8, mode AUDIO, at absoluteOffset 167237
DEBUG:whipper.image.toc:file data.wav, start 167205, length 18480
DEBUG:whipper.image.toc:appending source, counter 1, abs offset 167237, source <File u'data.wav'>
DEBUG:whipper.image.toc:at abs offset 167237, we are in source <File u'data.wav'>
DEBUG:whipper.image.toc:[track 08 index 00] added <Index 00 absolute 167237 path u'data.wav' relative 167205 counter 1>
DEBUG:whipper.image.toc:at abs offset 167490, we are in source <File u'data.wav'>
DEBUG:whipper.image.toc:[track 08 index 01] trackOffset 253, added <Index 01 absolute 167490 path u'data.wav' relative 167458 counter 1>
DEBUG:whipper.image.toc:found track 9, mode AUDIO, at absoluteOffset 185717
DEBUG:whipper.image.toc:file data.wav, start 185685, length 22290
DEBUG:whipper.image.toc:appending source, counter 1, abs offset 185717, source <File u'data.wav'>
DEBUG:whipper.image.toc:at abs offset 185717, we are in source <File u'data.wav'>
DEBUG:whipper.image.toc:[track 09 index 00] added <Index 00 absolute 185717 path u'data.wav' relative 185685 counter 1>
DEBUG:whipper.image.toc:at abs offset 185952, we are in source <File u'data.wav'>
DEBUG:whipper.image.toc:[track 09 index 01] trackOffset 235, added <Index 01 absolute 185952 path u'data.wav' relative 185920 counter 1>
DEBUG:whipper.image.toc:found track 10, mode AUDIO, at absoluteOffset 208007
DEBUG:whipper.image.toc:file data.wav, start 207975, length 21275
DEBUG:whipper.image.toc:appending source, counter 1, abs offset 208007, source <File u'data.wav'>
DEBUG:whipper.image.toc:at abs offset 208007, we are in source <File u'data.wav'>
DEBUG:whipper.image.toc:[track 10 index 00] added <Index 00 absolute 208007 path u'data.wav' relative 207975 counter 1>
DEBUG:whipper.image.toc:at abs offset 208337, we are in source <File u'data.wav'>
DEBUG:whipper.image.toc:[track 10 index 01] trackOffset 330, added <Index 01 absolute 208337 path u'data.wav' relative 208305 counter 1>
DEBUG:whipper.image.toc:parse: leadout: 229282
DEBUG:whipper.extern.task.task:stopping
DEBUG:whipper.extern.task.task:reset runner to None
DEBUG:whipper.extern.task.task:stopped task <whipper.program.cdrdao.ReadTOCTask object at 0x7f014d8fff50>
DEBUG:whipper.extern.task.task:done running task <whipper.program.cdrdao.ReadTOCTask object at 0x7f014d8fff50>
DEBUG:whipper.image.table:leadout LBA: 229282
DEBUG:whipper.image.table:cddb values: DiscID(offsets=[182, 20820, 48650, 70075, 104647, 128940, 146042, 167640, 186102, 208487], total_length=3057, track_count=10, playable_length=3057)
DEBUG:whipper.image.table:cddb disc id debug: a10bf10a 10 182 20820 48650 70075 104647 128940 146042 167640 186102 208487 3059
DEBUG:whipper.common.cache:result for cddbdiscid 'a10bf10a' not in cache
DEBUG:whipper.common.cache:creating result
DEBUG:whipper.image.table:leadout LBA: 229282
DEBUG:whipper.image.table:cddb values: DiscID(offsets=[182, 20820, 48650, 70075, 104647, 128940, 146042, 167640, 186102, 208487], total_length=3057, track_count=10, playable_length=3057)
DEBUG:whipper.image.table:cddb disc id debug: a10bf10a 10 182 20820 48650 70075 104647 128940 146042 167640 186102 208487 3059
CDDB disc id: a10bf10a
DEBUG:whipper.image.table:MusicBrainz values: [1, 10, 229432, 182, 20820, 48650, 70075, 104647, 128940, 146042, 167640, 186102, 208487]
DEBUG:whipper.image.table:getMusicBrainzDiscId: returning '7S3aV_4IdfIq61CpY38WJJI8iUE-'
MusicBrainz disc id 7S3aV_4IdfIq61CpY38WJJI8iUE-
DEBUG:whipper.common.config:loaded 2 sections from config file
DEBUG:whipper.image.table:getMusicBrainzDiscId: returning cached '7S3aV_4IdfIq61CpY38WJJI8iUE-'
DEBUG:whipper.image.table:MusicBrainz values: [1, 10, 229432, 182, 20820, 48650, 70075, 104647, 128940, 146042, 167640, 186102, 208487]
MusicBrainz lookup URL https://musicbrainz.org/cdtoc/attach?toc=1+10+229432+182+20820+48650+70075+104647+128940+146042+167640+186102+208487&tracks=10&id=7S3aV_4IdfIq61CpY38WJJI8iUE-
DEBUG:whipper.image.table:leadout LBA: 229282
Disc duration: 00:50:56.666, 10 audio tracks
DEBUG:whipper.common.config:loaded 2 sections from config file
DEBUG:whipper.image.table:getMusicBrainzDiscId: returning cached '7S3aV_4IdfIq61CpY38WJJI8iUE-'
DEBUG:whipper.image.table:MusicBrainz values: [1, 10, 229432, 182, 20820, 48650, 70075, 104647, 128940, 146042, 167640, 186102, 208487]
DEBUG:whipper.common.program:MusicBrainz submit url: 'https://musicbrainz.org/cdtoc/attach?toc=1+10+229432+182+20820+48650+70075+104647+128940+146042+167640+186102+208487&tracks=10&id=7S3aV_4IdfIq61CpY38WJJI8iUE-'
DEBUG:whipper.common.mbngs:looking up results for discid '7S3aV_4IdfIq61CpY38WJJI8iUE-'
WARNING:whipper.common.program:release not found: (NotFoundException(ResponseError(),),)
WARNING:whipper.common.program:continuing without metadata
Submit this disc to MusicBrainz at the above URL.

DEBUG:whipper.image.table:leadout LBA: 229282
DEBUG:whipper.image.table:cddb values: DiscID(offsets=[182, 20820, 48650, 70075, 104647, 128940, 146042, 167640, 186102, 208487], total_length=3057, track_count=10, playable_length=3057)
DEBUG:whipper.image.table:cddb disc id debug: a10bf10a 10 182 20820 48650 70075 104647 128940 146042 167640 186102 208487 3059
DEBUG:whipper.common.program:CDDB query result: <generator object perform_lookup at 0x7f014d90f550>
INFO:whipper.command.cd:FreeDB identifies disc as [u'Various / Salsa High Energy']
CRITICAL:whipper.command.cd:unable to retrieve disc metadata, --unknown argument not passed
rsmith@engine37:~/Music/riptest$

[JoeLametta]

Thanks for bug report.

@Freso, @MerlijnWajer I didn't try to replicate this issue but what's your opinion about this? (Should whipper eject the disc even in this case?)

[JoeLametta]

Ping @Freso, @MerlijnWajer