-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit tags before rip the CD without needing to use Musicbrainz database. #342
Comments
I would also like this feature. The use cases that I have for it are:
I know it is possible to use other programs to edit metadata afterwards but then the cue sheet titles won't match. If whipper opened the metadata in a text editor for editing it would also be possible to store this text file in the output directory so if I ever need to rerip the CD I could reuse the text file with my modifications. |
Just created an account here. This feature would really be cool to have. The use cases are obviously, I can absolutely confirm srussels thoughts on this. |
This patch is a hack I have been using for a few months to work around this issue. It adds an "--edit" option that writes the metadata to a text file, opens it in an editor for the user to update, then parses it back into whipper before continuing with the rip. |
@srussel I can't seem to apply that to the latest version -- would you mind submitting a PR or putting it up on a fork? |
Very cool hack tbh, it would be cool to have it done like this in official whipper. |
Yusss thank you! |
@srussel I tested https://github.com/srussel/whipper/commits/edit-metadata with CD which occurs #453 . |
@oech3 I have rebased my patch https://github.com/srussel/whipper/tree/edit-metadata |
@oech3 I found I was only updating the title, not the disambiguated title, which depending on whether you were using |
@srussel Thankyou.I can rip now. |
thanks for the work @srussel ! |
Hello, would be nice if we could Edit the CD and tracks informations manually without needing the Musicbrainz database because sometimes we found wrong filenames and CD titles on Musicbrainz.
The text was updated successfully, but these errors were encountered: