Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AccurateRip DB to verify individual tracks while ripping, keep temporary files until successful rip #266

Open
mtdcr opened this issue May 7, 2018 · 0 comments
Labels
Feature New feature Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) On Hold Waiting for other actions

Comments

@mtdcr
Copy link
Contributor

mtdcr commented May 7, 2018

Just an idea: Maybe a future version of whipper could fetch AccurateRip results for a disc before extracting tracks and, if present with high enough (user configurable?) confidence, verify each track with these checksums instead of reading each track twice and comparing two CRCs.

This may improve the ability to extract scratched tracks, because a) two identical CRCs don't reliably indicate lack of errors and b) if 50% of extractions have errors, you'll get a correct rip with an average of two reads with this technique, but - in the worst case - might never finish successfully when requiring two correct consecutive reads.

Maybe another less invasive way to improve the success rate would be to keep the result of each try on disk and compare CRCs of all tries, until two (or user configurable number of) files match. Or at least not throw away both results on a mismatch, but only the first one.

@JoeLametta JoeLametta added the idea label May 8, 2018
@JoeLametta JoeLametta added Feature New feature On Hold Waiting for other actions Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) and removed idea labels Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) On Hold Waiting for other actions
Projects
None yet
Development

No branches or pull requests

2 participants