Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative tagging for classical releases #191

Open
gorgobacka opened this issue Sep 17, 2017 · 3 comments
Open

Alternative tagging for classical releases #191

gorgobacka opened this issue Sep 17, 2017 · 3 comments
Labels
Accepted Accepted issue on our roadmap Feature New feature Needed: patch A pull request is required Priority: low Low priority Sprintable Small enough to sprint on
Milestone

Comments

@gorgobacka
Copy link
Contributor

As mentioned here: #156

"In MusicBrainz, classical releases have the composer as the Track artist and the performers as the Recording artist(s)."

Maybe introduce a switch for a non-default/alternative tagging that reflects this.

@JoeLametta JoeLametta added this to the 2.0 milestone Apr 6, 2018
@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Priority: low Low priority Feature New feature Sprintable Small enough to sprint on Needed: patch A pull request is required and removed idea labels Nov 12, 2018
@Freso
Copy link
Member

Freso commented Jan 7, 2020

Hey @gorgobacka. There’s a pull request being worked on now at #444 but I’m not sure it actually does what you are asking about here.

Can you be more explicit in clarifying what you’d like a --classical option to do for you?

@gorgobacka
Copy link
Contributor Author

Sorry, I don't know much about tagging classical releases. But whenever, I touched that topic (Picard plugins, Musicbrainz Forum, ...) it seems that there are some different rules. Therefore, I thought, I might be a good idea to have that.

But I suggest, that it can be explicitly applied via a parameter (--classical sounds great) and does not apply the tagging based on some automatic detection.

@stormwatch
Copy link

If you do implement this at some point, please use something meaningful rather than "--classical", maybe even generalize towards a conditional tagging behaviour based on a certain rule, in this case, the MusicBrainz genre value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Feature New feature Needed: patch A pull request is required Priority: low Low priority Sprintable Small enough to sprint on
Projects
None yet
Development

No branches or pull requests

5 participants