From 236544dce905edf90e51954c91d501f297f465eb Mon Sep 17 00:00:00 2001 From: JoeLametta Date: Mon, 17 May 2021 10:26:38 +0000 Subject: [PATCH] Push whipper release v0.10.0 Fixes #428. Signed-off-by: JoeLametta --- .travis.yml | 2 +- CHANGELOG.md | 245 +++++++++++++++++++++++--------------- COVERAGE | 75 ++++++------ PKG-INFO | 1 + README.md | 12 +- whipper/command/offset.py | 24 ++-- 6 files changed, 206 insertions(+), 153 deletions(-) create mode 100644 PKG-INFO diff --git a/.travis.yml b/.travis.yml index 5ac478e0..6636a5f2 100644 --- a/.travis.yml +++ b/.travis.yml @@ -26,7 +26,7 @@ jobs: - python: "3.5" - python: "3.10-dev" include: - - python: 3.8 + - python: 3.9 env: FLAKE8=true install: diff --git a/CHANGELOG.md b/CHANGELOG.md index 73c916f6..cf3ad34b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,25 +2,113 @@ ## [Unreleased](https://github.com/whipper-team/whipper/tree/HEAD) -[Full Changelog](https://github.com/whipper-team/whipper/compare/v0.9.0...HEAD) +[Full Changelog](https://github.com/whipper-team/whipper/compare/v0.10.0...HEAD) -## [v0.9.0](https://github.com/whipper-team/whipper/tree/v0.9.0) (2019-11-04) +## [v0.10.0](https://github.com/whipper-team/whipper/tree/v0.10.0) (2021-05-17) -[Full Changelog](https://github.com/whipper-team/whipper/compare/v0.8.0...v0.9.0) +[Full Changelog](https://github.com/whipper-team/whipper/compare/v0.9.0...v0.10.0) + +**Implemented enhancements:** + +- Add checks and warnings for \(known\) cdparanoia's upstream bugs [\#495](https://github.com/whipper-team/whipper/issues/495) [[Design](https://github.com/whipper-team/whipper/labels/Design)] +- Allow configuring whether to auto close the drive's tray [\#488](https://github.com/whipper-team/whipper/issues/488) +- Better error handling for unconfigured drive offset [\#478](https://github.com/whipper-team/whipper/issues/478) [[Design](https://github.com/whipper-team/whipper/labels/Design)] +- WARNING:whipper.command.main:set\_hostname\(\) takes 1 positional argument but 2 were given [\#464](https://github.com/whipper-team/whipper/issues/464) [[Design](https://github.com/whipper-team/whipper/labels/Design)] +- Display release country in matching releases [\#451](https://github.com/whipper-team/whipper/issues/451) +- Ability to group multi-disc releases in a single folder [\#448](https://github.com/whipper-team/whipper/issues/448) +- Provide option to not use disambiguation in title [\#440](https://github.com/whipper-team/whipper/issues/440) +- test\_result\_logger.py: truly test all four cases of whipper version scheme [\#427](https://github.com/whipper-team/whipper/issues/427) +- more template options for filenames [\#401](https://github.com/whipper-team/whipper/issues/401) +- Always print output directory [\#393](https://github.com/whipper-team/whipper/issues/393) [[Design](https://github.com/whipper-team/whipper/labels/Design)] +- Provide better error message when there's no CD in the drive [\#385](https://github.com/whipper-team/whipper/issues/385) [[Design](https://github.com/whipper-team/whipper/labels/Design)] +- Change documentation from epydoc to reStructuredText [\#383](https://github.com/whipper-team/whipper/issues/383) +- Allow customization of maximum rip retries attempts value [\#349](https://github.com/whipper-team/whipper/issues/349) +- Save ISRCs from CD TOC [\#320](https://github.com/whipper-team/whipper/issues/320) +- PathFilter questions [\#313](https://github.com/whipper-team/whipper/issues/313) +- Let `debug musicbrainzngs` look up based on MusicBrainz Release ID in addition to Disc ID [\#251](https://github.com/whipper-team/whipper/issues/251) +- Ability to skip unrippable track [\#128](https://github.com/whipper-team/whipper/issues/128) +- add manpage [\#73](https://github.com/whipper-team/whipper/issues/73) +- Grab cover art [\#50](https://github.com/whipper-team/whipper/issues/50) +- cdda2wav from cdrtools instead of cdparanoia [\#38](https://github.com/whipper-team/whipper/issues/38) + +**Fixed bugs:** + +- Unable to find offset with a single-track cd [\#532](https://github.com/whipper-team/whipper/issues/532) +- Rip of CD fails to set "Various Artists" flac tag [\#518](https://github.com/whipper-team/whipper/issues/518) +- AccurateRipResponse test failures [\#515](https://github.com/whipper-team/whipper/issues/515) +- path\_filter\_whitespace not working [\#513](https://github.com/whipper-team/whipper/issues/513) +- got exception IndexError\('list index out of range'\) [\#512](https://github.com/whipper-team/whipper/issues/512) +- no CD detected, please insert one and retry [\#511](https://github.com/whipper-team/whipper/issues/511) [[Regression](https://github.com/whipper-team/whipper/labels/Regression)] +- whipper not finding the drive \(whipper docker install\) [\#499](https://github.com/whipper-team/whipper/issues/499) +- Missing .toc files when ripping a CD multiple times due to whipper ToC caching [\#486](https://github.com/whipper-team/whipper/issues/486) +- Change the docker alias in the readme to use {HOME} rather than ~ [\#482](https://github.com/whipper-team/whipper/issues/482) +- Musicbrainz lookup fails for multiple CD rip [\#477](https://github.com/whipper-team/whipper/issues/477) +- whipper drive analyze appears to be stuck [\#469](https://github.com/whipper-team/whipper/issues/469) [[Upstream Bug](https://github.com/whipper-team/whipper/labels/Upstream%20Bug)] +- Whipper configuration file: `cover_art` option does nothing [\#465](https://github.com/whipper-team/whipper/issues/465) [[Design](https://github.com/whipper-team/whipper/labels/Design)] +- Improve Docker instructions in README [\#452](https://github.com/whipper-team/whipper/issues/452) +- Whipper gives up even if 5th rip attempt is successful [\#449](https://github.com/whipper-team/whipper/issues/449) +- Don't include full file path in log files [\#445](https://github.com/whipper-team/whipper/issues/445) [[Regression](https://github.com/whipper-team/whipper/labels/Regression)] +- Whipper example config file: `%` character in inline comment causes `InterpolationSyntaxError` [\#443](https://github.com/whipper-team/whipper/issues/443) +- output directory isn't read [\#441](https://github.com/whipper-team/whipper/issues/441) [[Regression](https://github.com/whipper-team/whipper/labels/Regression)] +- Requests to accuraterip.com are missing a user agent which identifies whipper [\#439](https://github.com/whipper-team/whipper/issues/439) +- Bug: MusicBrainz lookup URL is hardcoded to always use https [\#437](https://github.com/whipper-team/whipper/issues/437) +- `whipper drive analyze` is broken on Python 3 [\#431](https://github.com/whipper-team/whipper/issues/431) [[Regression](https://github.com/whipper-team/whipper/labels/Regression)] +- Make it possible to build from tarball again [\#428](https://github.com/whipper-team/whipper/issues/428) [[Regression](https://github.com/whipper-team/whipper/labels/Regression)] +- TypeError: float argument required, not NoneType [\#402](https://github.com/whipper-team/whipper/issues/402) +- Drop whipper caching [\#335](https://github.com/whipper-team/whipper/issues/335) +- musicbrainz calculation fails on cd with data tracks that are not positioned at the end [\#289](https://github.com/whipper-team/whipper/issues/289) +- AttributeError: 'Namespace' object has no attribute 'offset' [\#230](https://github.com/whipper-team/whipper/issues/230) [[Regression](https://github.com/whipper-team/whipper/labels/Regression)] +- `'NoneType' object has no attribute '__getitem__'` after rip with current master \(a3e9260\) [\#196](https://github.com/whipper-team/whipper/issues/196) +- Use the track title instead the recoding title \(MusicBrainz related\) [\#192](https://github.com/whipper-team/whipper/issues/192) +- pygobject\_register\_sinkfunc is deprecated [\#45](https://github.com/whipper-team/whipper/issues/45) + +**Merged pull requests:** + +- Fixed error when ripping using `--keep-going` without specifying `--o… [\#537](https://github.com/whipper-team/whipper/pull/537) ([blueblots](https://github.com/blueblots)) +- Add requested template variables [\#536](https://github.com/whipper-team/whipper/pull/536) ([JoeLametta](https://github.com/JoeLametta)) +- Added --keep-going option to cd rip command [\#524](https://github.com/whipper-team/whipper/pull/524) ([blueblots](https://github.com/blueblots)) +- Parameterise the UID of the worker user in the docker build file. [\#517](https://github.com/whipper-team/whipper/pull/517) ([unclealex72](https://github.com/unclealex72)) +- Fix capitalization of "Health status" in rip log [\#510](https://github.com/whipper-team/whipper/pull/510) ([MasterOdin](https://github.com/MasterOdin)) +- Tag audio tracks with ISRCs \(if available\) [\#509](https://github.com/whipper-team/whipper/pull/509) ([JoeLametta](https://github.com/JoeLametta)) +- Provide better error message when there's no CD in the drive [\#507](https://github.com/whipper-team/whipper/pull/507) ([JoeLametta](https://github.com/JoeLametta)) +- Add checks and warnings for \(known\) cdparanoia's upstream bugs [\#506](https://github.com/whipper-team/whipper/pull/506) ([JoeLametta](https://github.com/JoeLametta)) +- Allow configuring whether to auto close the drive's tray [\#505](https://github.com/whipper-team/whipper/pull/505) ([JoeLametta](https://github.com/JoeLametta)) +- Travis CI: Add Python 3.9 release candidate 1 [\#504](https://github.com/whipper-team/whipper/pull/504) ([cclauss](https://github.com/cclauss)) +- Define libcdio version as environment variables in docker [\#498](https://github.com/whipper-team/whipper/pull/498) ([MasterOdin](https://github.com/MasterOdin)) +- Add man pages. [\#490](https://github.com/whipper-team/whipper/pull/490) ([baldurmen](https://github.com/baldurmen)) +- Restore the ability to use inline comments in config files [\#461](https://github.com/whipper-team/whipper/pull/461) ([neilmayhew](https://github.com/neilmayhew)) +- Fix cd rip --max-retries option handling [\#460](https://github.com/whipper-team/whipper/pull/460) ([kevinoid](https://github.com/kevinoid)) +- Fix crash fetching cover art for unknown album [\#459](https://github.com/whipper-team/whipper/pull/459) ([kevinoid](https://github.com/kevinoid)) +- Fix cover file saving with /tmp on different FS [\#458](https://github.com/whipper-team/whipper/pull/458) ([kevinoid](https://github.com/kevinoid)) +- Test all four cases of whipper version scheme [\#456](https://github.com/whipper-team/whipper/pull/456) ([ABCbum](https://github.com/ABCbum)) +- Allow customization of maximum rip attempts value [\#455](https://github.com/whipper-team/whipper/pull/455) ([ABCbum](https://github.com/ABCbum)) +- Update docker instructions to use --bind instead of -v. [\#454](https://github.com/whipper-team/whipper/pull/454) ([MartinPaulEve](https://github.com/MartinPaulEve)) +- Use https and http appropriately when connecting to MusicBrainz [\#450](https://github.com/whipper-team/whipper/pull/450) ([ABCbum](https://github.com/ABCbum)) +- Add PERFORMER & COMPOSER metadata tags to audio tracks \(if available\) [\#444](https://github.com/whipper-team/whipper/pull/444) ([ABCbum](https://github.com/ABCbum)) +- Grab cover art from MusicBrainz/Cover Art Archive and add it to the resulting whipper rips [\#436](https://github.com/whipper-team/whipper/pull/436) ([ABCbum](https://github.com/ABCbum)) +- Fix whipper's MusicBrainz Disc ID calculation for CDs with data tracks that are not positioned at the end of the disc [\#435](https://github.com/whipper-team/whipper/pull/435) ([ABCbum](https://github.com/ABCbum)) +- Fix failed\(\) task of AnalyzeTask \(program/cdparanoia\) [\#434](https://github.com/whipper-team/whipper/pull/434) ([Freso](https://github.com/Freso)) +- Test against Python versions 3.6, 3.7, and 3.8 [\#433](https://github.com/whipper-team/whipper/pull/433) ([Freso](https://github.com/Freso)) +- Allow whipper's mblookup command to look up information based on Release MBID [\#432](https://github.com/whipper-team/whipper/pull/432) ([ABCbum](https://github.com/ABCbum)) +- Enable whipper to use track title [\#430](https://github.com/whipper-team/whipper/pull/430) ([ABCbum](https://github.com/ABCbum)) +- Improve docstrings [\#389](https://github.com/whipper-team/whipper/pull/389) ([JoeLametta](https://github.com/JoeLametta)) +- Drop whipper caching [\#336](https://github.com/whipper-team/whipper/pull/336) ([JoeLametta](https://github.com/JoeLametta)) +- Rewrite PathFilter [\#324](https://github.com/whipper-team/whipper/pull/324) ([JoeLametta](https://github.com/JoeLametta)) + +## [v0.9.0](https://github.com/whipper-team/whipper/tree/v0.9.0) (2019-12-04) +[Full Changelog](https://github.com/whipper-team/whipper/compare/v0.8.0...v0.9.0) **Fixed bugs:** -- Fix regression introduced due to Python 3 port [\#424](https://github.com/whipper-team/whipper/issues/424) -- Properly tagging releases on dockerhub [\#423](https://github.com/whipper-team/whipper/issues/423) +- Fix regression introduced due to Python 3 port [\#424](https://github.com/whipper-team/whipper/issues/424) [[Regression](https://github.com/whipper-team/whipper/labels/Regression)] - Test failure when building a release [\#420](https://github.com/whipper-team/whipper/issues/420) - Dockerfile is missing ruamel.yaml [\#419](https://github.com/whipper-team/whipper/issues/419) +- exception while reading CD [\#413](https://github.com/whipper-team/whipper/issues/413) +- Unable to find offset using specific CD. [\#252](https://github.com/whipper-team/whipper/issues/252) +- cdparanoia toc does not agree with cdrdao-toc, cd-paranoia also reports different \(but better\) lengths [\#175](https://github.com/whipper-team/whipper/issues/175) [[Upstream Bug](https://github.com/whipper-team/whipper/labels/Upstream%20Bug)] - Port to Python 3 [\#78](https://github.com/whipper-team/whipper/issues/78) -**Closed issues:** - -- Why is CD-Text if found not used for naming Disk and Tracks? [\#397](https://github.com/whipper-team/whipper/issues/397) - **Merged pull requests:** - Python 3 port [\#411](https://github.com/whipper-team/whipper/pull/411) ([ddevault](https://github.com/ddevault)) @@ -31,31 +119,27 @@ **Implemented enhancements:** +- Separate out Release in log into two value map [\#416](https://github.com/whipper-team/whipper/issues/416) - Include MusicBrainz Release ID in the log file [\#381](https://github.com/whipper-team/whipper/issues/381) +- Note in the whipper output/log if development version was used [\#337](https://github.com/whipper-team/whipper/issues/337) [[Design](https://github.com/whipper-team/whipper/labels/Design)] +- read-toc progress information [\#299](https://github.com/whipper-team/whipper/issues/299) [[Design](https://github.com/whipper-team/whipper/labels/Design)] +- Look into adding more MusicBrainz identifiers to ripped files [\#200](https://github.com/whipper-team/whipper/issues/200) - Specify supported version\(s\) of Python in setup.py [\#378](https://github.com/whipper-team/whipper/pull/378) ([Freso](https://github.com/Freso)) **Fixed bugs:** - whipper bails out if MusicBrainz release group doesn’t have a type [\#396](https://github.com/whipper-team/whipper/issues/396) -- object has no attribute 'working\_directory' when running cd info [\#375](https://github.com/whipper-team/whipper/issues/375) -- Failure to rip CD: "ValueError: could not convert string to float: " [\#374](https://github.com/whipper-team/whipper/issues/374) -- "AttributeError: Program instance has no attribute '\_presult'" when ripping [\#369](https://github.com/whipper-team/whipper/issues/369) +- object has no attribute 'working\_directory' when running cd info [\#375](https://github.com/whipper-team/whipper/issues/375) [[Regression](https://github.com/whipper-team/whipper/labels/Regression)] +- Failure to rip CD: "ValueError: could not convert string to float: " [\#374](https://github.com/whipper-team/whipper/issues/374) [[Regression](https://github.com/whipper-team/whipper/labels/Regression)] +- "AttributeError: Program instance has no attribute '\_presult'" when ripping [\#369](https://github.com/whipper-team/whipper/issues/369) [[Regression](https://github.com/whipper-team/whipper/labels/Regression)] - Drive analysis fails [\#361](https://github.com/whipper-team/whipper/issues/361) -- Eliminate warning "eject: CD-ROM tray close command failed" [\#354](https://github.com/whipper-team/whipper/issues/354) +- Eliminate warning "eject: CD-ROM tray close command failed" [\#354](https://github.com/whipper-team/whipper/issues/354) [[Design](https://github.com/whipper-team/whipper/labels/Design)] - Flac file permissions [\#284](https://github.com/whipper-team/whipper/issues/284) **Closed issues:** -- Separate out Release in log into two value map [\#416](https://github.com/whipper-team/whipper/issues/416) -- Network issue [\#412](https://github.com/whipper-team/whipper/issues/412) -- RequestsDependencyWarning: urllib3 \(1.25.2\) or chardet \(3.0.4\) doesn't match a supported version [\#400](https://github.com/whipper-team/whipper/issues/400) - Add git/mercurial dependency to the README [\#386](https://github.com/whipper-team/whipper/issues/386) -- Doesn't eject - "eject: unable to eject" \(but manual eject works\) [\#355](https://github.com/whipper-team/whipper/issues/355) -- Note in the whipper output/log if development version was used [\#337](https://github.com/whipper-team/whipper/issues/337) -- fedora 29, whipper 0.72, Error While Executing Any Command [\#332](https://github.com/whipper-team/whipper/issues/332) -- read-toc progress information [\#299](https://github.com/whipper-team/whipper/issues/299) -- ripping fails frequently, but not repeatably [\#290](https://github.com/whipper-team/whipper/issues/290) -- Look into adding more MusicBrainz identifiers to ripped files [\#200](https://github.com/whipper-team/whipper/issues/200) +- Rip while entering MusicBrainz data [\#360](https://github.com/whipper-team/whipper/issues/360) **Merged pull requests:** @@ -90,25 +174,27 @@ [Full Changelog](https://github.com/whipper-team/whipper/compare/v0.7.2...v0.7.3) +**Implemented enhancements:** + +- Write musicbrainz\_discid tag when disc is unknown [\#280](https://github.com/whipper-team/whipper/issues/280) +- Write .toc files in addition to .cue files to support cdrdao and non-compliant .cue sheets [\#214](https://github.com/whipper-team/whipper/issues/214) + **Fixed bugs:** - Error when parsing log file due to left pad track number [\#340](https://github.com/whipper-team/whipper/issues/340) -- Failing AccurateRipResponse tests [\#333](https://github.com/whipper-team/whipper/issues/333) +- Failing AccurateRipResponse tests [\#333](https://github.com/whipper-team/whipper/issues/333) [[Regression](https://github.com/whipper-team/whipper/labels/Regression)] +- CRITICAL:whipper.command.cd:output directory is a finished rip output directory [\#287](https://github.com/whipper-team/whipper/issues/287) +- Possible HTOA error [\#281](https://github.com/whipper-team/whipper/issues/281) [[Upstream Bug](https://github.com/whipper-team/whipper/labels/Upstream%20Bug)] - Disc template KeyError [\#279](https://github.com/whipper-team/whipper/issues/279) +- Enhanced CD causes computer to freeze. [\#256](https://github.com/whipper-team/whipper/issues/256) [[Upstream Bug](https://github.com/whipper-team/whipper/labels/Upstream%20Bug)] - Unicode issues [\#215](https://github.com/whipper-team/whipper/issues/215) - whipper offset find exception [\#208](https://github.com/whipper-team/whipper/issues/208) - ZeroDivisionError: float division by zero [\#202](https://github.com/whipper-team/whipper/issues/202) -- Allow plugins from system directories [\#135](https://github.com/whipper-team/whipper/issues/135) +- Allow plugins from system directories [\#135](https://github.com/whipper-team/whipper/issues/135) [[Regression](https://github.com/whipper-team/whipper/labels/Regression)] **Closed issues:** -- On Ubuntu 18.10 cd-paranoia binary is called cdparanoia [\#347](https://github.com/whipper-team/whipper/issues/347) -- WARNING:whipper.common.program:network error: NetworkError\(\) [\#338](https://github.com/whipper-team/whipper/issues/338) -- Can not install [\#314](https://github.com/whipper-team/whipper/issues/314) -- use standard logging [\#303](https://github.com/whipper-team/whipper/issues/303) -- Write musicbrainz\_discid tag when disc is unknown [\#280](https://github.com/whipper-team/whipper/issues/280) -- pycdio & libcdio issues [\#238](https://github.com/whipper-team/whipper/issues/238) -- Write .toc files in addition to .cue files to support cdrdao and non-compliant .cue sheets [\#214](https://github.com/whipper-team/whipper/issues/214) +- use standard logging [\#303](https://github.com/whipper-team/whipper/issues/303) [[Design](https://github.com/whipper-team/whipper/labels/Design)] **Merged pull requests:** @@ -128,15 +214,13 @@ [Full Changelog](https://github.com/whipper-team/whipper/compare/v0.7.1...v0.7.2) -**Fixed bugs:** +**Implemented enhancements:** -- UnicodeEncodeError: 'ascii' codec can't encode characters in position 17-18: ordinal not in range\(128\) [\#315](https://github.com/whipper-team/whipper/issues/315) +- automatically build Docker images [\#301](https://github.com/whipper-team/whipper/issues/301) -**Closed issues:** +**Fixed bugs:** -- Add whipper to Hydrogen Audio wiki's "Comparison of CD rippers" [\#317](https://github.com/whipper-team/whipper/issues/317) -- Make 0.7.1 release \(before GCI 😅\) [\#312](https://github.com/whipper-team/whipper/issues/312) -- automatically build Docker images [\#301](https://github.com/whipper-team/whipper/issues/301) +- UnicodeEncodeError: 'ascii' codec can't encode characters in position 17-18: ordinal not in range\(128\) [\#315](https://github.com/whipper-team/whipper/issues/315) **Merged pull requests:** @@ -147,6 +231,12 @@ [Full Changelog](https://github.com/whipper-team/whipper/compare/v0.7.0...v0.7.1) +**Implemented enhancements:** + +- Disable eject button when ripping [\#308](https://github.com/whipper-team/whipper/issues/308) +- Add cdparanoia version to log file [\#267](https://github.com/whipper-team/whipper/issues/267) +- Add a requirements.txt file [\#221](https://github.com/whipper-team/whipper/issues/221) + **Fixed bugs:** - TypeError on whipper offset find [\#263](https://github.com/whipper-team/whipper/issues/263) @@ -156,16 +246,6 @@ - Limit length of filenames [\#197](https://github.com/whipper-team/whipper/issues/197) - Loggers [\#117](https://github.com/whipper-team/whipper/issues/117) -**Closed issues:** - -- Disable eject button when ripping [\#308](https://github.com/whipper-team/whipper/issues/308) -- Transfer repository ownership to GitHub organization [\#306](https://github.com/whipper-team/whipper/issues/306) -- Variable offset detected [\#295](https://github.com/whipper-team/whipper/issues/295) -- Github repo [\#293](https://github.com/whipper-team/whipper/issues/293) -- pre emphasis documentation [\#275](https://github.com/whipper-team/whipper/issues/275) -- Add cdparanoia version to log file [\#267](https://github.com/whipper-team/whipper/issues/267) -- Add a requirements.txt file [\#221](https://github.com/whipper-team/whipper/issues/221) - **Merged pull requests:** - Limit length of filenames [\#311](https://github.com/whipper-team/whipper/pull/311) ([JoeLametta](https://github.com/JoeLametta)) @@ -192,17 +272,11 @@ **Fixed bugs:** -- cd rip is not able to rip the last track [\#203](https://github.com/whipper-team/whipper/issues/203) +- cd rip is not able to rip the last track [\#203](https://github.com/whipper-team/whipper/issues/203) [[Upstream Bug](https://github.com/whipper-team/whipper/labels/Upstream%20Bug)] +- CD-ROM powers off during rip command. [\#189](https://github.com/whipper-team/whipper/issues/189) [[Upstream Bug](https://github.com/whipper-team/whipper/labels/Upstream%20Bug)] - Various ripping issues [\#179](https://github.com/whipper-team/whipper/issues/179) - whipper not picking up all settings in whipper.conf [\#99](https://github.com/whipper-team/whipper/issues/99) -**Closed issues:** - -- How to choose device \(if there are more\)? [\#241](https://github.com/whipper-team/whipper/issues/241) -- Make a 0.6.0 release [\#219](https://github.com/whipper-team/whipper/issues/219) -- flac settings [\#184](https://github.com/whipper-team/whipper/issues/184) -- Remove connection to parent fork. [\#79](https://github.com/whipper-team/whipper/issues/79) - **Merged pull requests:** - Small readme cleanups [\#250](https://github.com/whipper-team/whipper/pull/250) ([RecursiveForest](https://github.com/RecursiveForest)) @@ -222,14 +296,19 @@ **Implemented enhancements:** +- using your own MusicBrainz server [\#172](https://github.com/whipper-team/whipper/issues/172) +- Use 'Artist as credited' in filename instead of 'Artist in MusicBrainz' \(e.g. to solve \[unknown\]\) [\#155](https://github.com/whipper-team/whipper/issues/155) - Declare supported Python version [\#152](https://github.com/whipper-team/whipper/issues/152) +- Identify media type in log file \(ie CD vs CD-R\) [\#137](https://github.com/whipper-team/whipper/issues/137) +- Rename the Python module [\#100](https://github.com/whipper-team/whipper/issues/100) +- libcdio-paranoia instead of cdparanoia [\#87](https://github.com/whipper-team/whipper/issues/87) +- Support both AccurateRip V1 and AccurateRip V2 at the same time [\#18](https://github.com/whipper-team/whipper/issues/18) **Fixed bugs:** - Error: NotFoundException message displayed while ripping an unknown disc [\#198](https://github.com/whipper-team/whipper/issues/198) - whipper doesn't name files .flac, which leads to it not being able to find ripped files [\#194](https://github.com/whipper-team/whipper/issues/194) -- Issues with finding offset [\#182](https://github.com/whipper-team/whipper/issues/182) -- cdparanoia toc does not agree with cdrdao-toc, cd-paranoia also reports different \(but better\) lengths [\#175](https://github.com/whipper-team/whipper/issues/175) +- Issues with finding offset [\#182](https://github.com/whipper-team/whipper/issues/182) [[Upstream Bug](https://github.com/whipper-team/whipper/labels/Upstream%20Bug)] - failing unittests in systemd-nspawn container [\#157](https://github.com/whipper-team/whipper/issues/157) - Update doc/release or remove it [\#149](https://github.com/whipper-team/whipper/issues/149) - Test HTOA peak value against 0 \(integer equality\) [\#143](https://github.com/whipper-team/whipper/issues/143) @@ -239,19 +318,6 @@ - ERROR: stopping task which is already stopped [\#59](https://github.com/whipper-team/whipper/issues/59) - can't find accuraterip-checksum binary in morituri-uninstalled mode [\#47](https://github.com/whipper-team/whipper/issues/47) -**Closed issues:** - -- ImportError - CDDB on Solus. [\#209](https://github.com/whipper-team/whipper/issues/209) -- rename milestone 101010 to backlog [\#190](https://github.com/whipper-team/whipper/issues/190) -- .log, .cue, and .m3u file names [\#180](https://github.com/whipper-team/whipper/issues/180) -- using your own MusicBrainz server [\#172](https://github.com/whipper-team/whipper/issues/172) -- Use 'Artist as credited' in filename instead of 'Artist in MusicBrainz' \(e.g. to solve \[unknown\]\) [\#155](https://github.com/whipper-team/whipper/issues/155) -- Identify media type in log file \(ie CD vs CD-R\) [\#137](https://github.com/whipper-team/whipper/issues/137) -- Rename the Python module [\#100](https://github.com/whipper-team/whipper/issues/100) -- libcdio-paranoia instead of cdparanoia [\#87](https://github.com/whipper-team/whipper/issues/87) -- Release, Tags, NEWS? [\#63](https://github.com/whipper-team/whipper/issues/63) -- Support both AccurateRip V1 and AccurateRip V2 at the same time [\#18](https://github.com/whipper-team/whipper/issues/18) - **Merged pull requests:** - Test HTOA peak value against 0 \(integer comparison\) [\#224](https://github.com/whipper-team/whipper/pull/224) ([JoeLametta](https://github.com/JoeLametta)) @@ -290,24 +356,19 @@ [Full Changelog](https://github.com/whipper-team/whipper/compare/v0.4.2...v0.5.0) +**Implemented enhancements:** + +- Remove gstreamer dependency [\#29](https://github.com/whipper-team/whipper/issues/29) + **Fixed bugs:** -- Final track rip failure due to file size mismatch [\#146](https://github.com/whipper-team/whipper/issues/146) +- Final track rip failure due to file size mismatch [\#146](https://github.com/whipper-team/whipper/issues/146) [[Upstream Bug](https://github.com/whipper-team/whipper/labels/Upstream%20Bug)] - Fails to rip if MB Release doesn't have a release date/year [\#133](https://github.com/whipper-team/whipper/issues/133) -- overly verbose warning logging [\#131](https://github.com/whipper-team/whipper/issues/131) +- overly verbose warning logging [\#131](https://github.com/whipper-team/whipper/issues/131) [[Design](https://github.com/whipper-team/whipper/labels/Design)] - fb271f08cdee877795091065c344dcc902d1dcbf breaks HEAD [\#129](https://github.com/whipper-team/whipper/issues/129) - 'whipper drive list' returns a suggestion to run 'rip offset find' [\#112](https://github.com/whipper-team/whipper/issues/112) - EmptyError\('not a single buffer gotten',\) [\#101](https://github.com/whipper-team/whipper/issues/101) -- Julie Roberts bug [\#74](https://github.com/whipper-team/whipper/issues/74) - -**Closed issues:** - -- `whipper find offset` still requiring gst [\#141](https://github.com/whipper-team/whipper/issues/141) -- Burn FLACs 1:1 CD ? [\#125](https://github.com/whipper-team/whipper/issues/125) -- Check that whipper deals properly with CD pre-emphasis [\#120](https://github.com/whipper-team/whipper/issues/120) -- Difficulty getting flac encoding working. [\#118](https://github.com/whipper-team/whipper/issues/118) -- additional tag creation [\#108](https://github.com/whipper-team/whipper/issues/108) -- Remove gstreamer dependency [\#29](https://github.com/whipper-team/whipper/issues/29) +- Julie Roberts bug [\#74](https://github.com/whipper-team/whipper/issues/74) [[Upstream Bug](https://github.com/whipper-team/whipper/labels/Upstream%20Bug)] **Merged pull requests:** @@ -329,10 +390,6 @@ - 0.4.1 Release created but version number in code not bumped [\#105](https://github.com/whipper-team/whipper/issues/105) - Whipper attempts to rip with no CD inserted [\#81](https://github.com/whipper-team/whipper/issues/81) -**Closed issues:** - -- Make a 0.4.1 release [\#104](https://github.com/whipper-team/whipper/issues/104) - **Merged pull requests:** - Amend previous tagged release [\#107](https://github.com/whipper-team/whipper/pull/107) ([JoeLametta](https://github.com/JoeLametta)) @@ -344,8 +401,7 @@ **Closed issues:** -- Please don't stop - despite the recent events \(ANSWERED\) [\#76](https://github.com/whipper-team/whipper/issues/76) -- Migrate away from the "rip" command [\#21](https://github.com/whipper-team/whipper/issues/21) +- Migrate away from the "rip" command [\#21](https://github.com/whipper-team/whipper/issues/21) [[Design](https://github.com/whipper-team/whipper/labels/Design)] **Merged pull requests:** @@ -406,6 +462,7 @@ **Implemented enhancements:** - Don't allow ripping without an explicit offset, and make pycdio a required dependency [\#23](https://github.com/whipper-team/whipper/issues/23) +- get rid of the gstreamer-0.10 dependency [\#2](https://github.com/whipper-team/whipper/issues/2) **Fixed bugs:** @@ -416,16 +473,6 @@ - rip offset find seems to fail [\#4](https://github.com/whipper-team/whipper/issues/4) - rip cd info seems to fail [\#3](https://github.com/whipper-team/whipper/issues/3) -**Closed issues:** - -- Error selecting Drive for ripping [\#34](https://github.com/whipper-team/whipper/issues/34) -- Offset not saved: could not get device info \(requires pycdio\) [\#33](https://github.com/whipper-team/whipper/issues/33) -- On Arch Linux, CDDB does not know how to install morituri. [\#28](https://github.com/whipper-team/whipper/issues/28) -- Minimal makedepends for building [\#17](https://github.com/whipper-team/whipper/issues/17) -- Delete stale branches [\#7](https://github.com/whipper-team/whipper/issues/7) -- get rid of the gstreamer-0.10 dependency [\#2](https://github.com/whipper-team/whipper/issues/2) -- Merge 'fork' into 'master' [\#1](https://github.com/whipper-team/whipper/issues/1) - **Merged pull requests:** - Issue24 [\#42](https://github.com/whipper-team/whipper/pull/42) ([JoeLametta](https://github.com/JoeLametta)) @@ -453,7 +500,7 @@ ## [v0.2.0](https://github.com/whipper-team/whipper/tree/v0.2.0) (2013-01-20) -[Full Changelog](https://github.com/whipper-team/whipper/compare/20421488be8a82606f7ae82a16c9d8bc015b9e01...v0.2.0) +[Full Changelog](https://github.com/whipper-team/whipper/compare/e84361b6534a116445bd27b48708fff9ffb589e9...v0.2.0) diff --git a/COVERAGE b/COVERAGE index a30a425a..3257ac52 100644 --- a/COVERAGE +++ b/COVERAGE @@ -1,55 +1,54 @@ -Coverage.py 4.5.4 text report against whipper v0.9.0 +Coverage.py 5.5 text report against whipper v0.10.0 $ coverage run --branch --omit='whipper/test/*' --source=whipper -m unittest discover $ coverage report -m Name Stmts Miss Branch BrPart Cover Missing ----------------------------------------------------------------------------- -whipper/__init__.py 15 5 4 2 63% 9-12, 16, 18, 15->16, 17->18 -whipper/__main__.py 7 7 2 0 0% 4-14 +whipper/__init__.py 15 5 4 2 63% 9-12, 16, 18 +whipper/__main__.py 6 6 2 0 0% 4-13 whipper/command/__init__.py 0 0 0 0 100% whipper/command/accurip.py 41 41 18 0 0% 21-90 -whipper/command/basecommand.py 69 29 30 8 53% 70, 72, 76, 82-88, 98-102, 107-114, 127, 129, 133, 139, 142-145, 68->70, 71->72, 75->76, 80->82, 96->98, 106->107, 126->127, 128->129 -whipper/command/cd.py 227 189 60 0 13% 72-80, 85-196, 199, 212, 236-288, 295-321, 324-493 +whipper/command/basecommand.py 68 29 30 8 52% 72, 74, 78, 84-90, 100-104, 109-116, 129, 131, 135, 141, 144-147 +whipper/command/cd.py 272 231 88 0 11% 81-89, 94-209, 212, 225, 252-324, 331-366, 369-594 whipper/command/drive.py 57 57 10 0 0% 21-107 -whipper/command/image.py 37 37 6 0 0% 21-75 -whipper/command/main.py 68 68 24 0 0% 4-116 -whipper/command/mblookup.py 29 3 8 2 86% 21-23, 35->37, 37->28 -whipper/command/offset.py 110 110 32 0 0% 21-219 +whipper/command/image.py 36 36 6 0 0% 21-73 +whipper/command/main.py 74 74 24 0 0% 4-133 +whipper/command/mblookup.py 39 3 14 2 91% 47-49, 63->72, 65->72 +whipper/command/offset.py 115 115 36 0 0% 21-225 whipper/common/__init__.py 0 0 0 0 100% -whipper/common/accurip.py 132 5 62 4 95% 118, 124, 133-135, 113->118, 119->124, 241->247, 251->257 -whipper/common/cache.py 100 48 34 5 44% 66-90, 96, 99, 107-110, 113-114, 138-142, 165-172, 196-201, 206-222, 95->96, 98->99, 136->146, 137->138, 164->165 +whipper/common/accurip.py 115 4 56 5 95% 79, 116, 125, 131, 223->229, 233->239 whipper/common/checksum.py 26 14 2 0 43% 41-42, 45-46, 49-64 -whipper/common/common.py 150 28 38 6 78% 51-52, 119-120, 143-144, 162-169, 181, 274-279, 286-291, 328-332, 118->119, 131->134, 180->181, 190->197, 271->274, 326->334 -whipper/common/config.py 90 8 18 4 89% 104-105, 123-124, 130, 140, 142, 144, 129->130, 139->140, 141->142, 143->144 -whipper/common/directory.py 18 5 4 0 68% 42-48 -whipper/common/drive.py 31 20 8 0 33% 35-40, 44-50, 54-60, 64-71 -whipper/common/encode.py 44 23 2 0 46% 37-38, 41-42, 45-46, 53-56, 59-60, 63-64, 76-77, 80-81, 84-91 -whipper/common/mbngs.py 174 52 66 7 70% 38-39, 45, 93-99, 174-175, 180-181, 227, 233, 258-260, 269, 289-344, 159->158, 173->174, 179->180, 226->227, 232->233, 257->258, 266->269 -whipper/common/path.py 24 0 8 3 91% 42->45, 52->56, 60->65 -whipper/common/program.py 345 267 117 5 19% 85-87, 93-104, 113-147, 156-161, 164, 169-173, 218, 229-230, 232-236, 253-268, 276-386, 397-455, 463-471, 475-490, 501-540, 552-569, 572-590, 593-603, 606-614, 76->79, 215->218, 228->229, 231->232, 238->242 -whipper/common/renamer.py 102 2 16 1 97% 133, 156, 58->66 -whipper/common/task.py 77 15 14 2 79% 47-52, 86-87, 102, 115-116, 123, 129, 135, 141, 147, 84->86, 99->102 +whipper/common/common.py 150 28 38 6 78% 51-52, 116-117, 128->131, 140-141, 156-163, 176, 185->192, 269-274, 279-284, 321->329, 323-327 +whipper/common/config.py 89 6 18 4 91% 107, 117, 119, 121, 147-148 +whipper/common/directory.py 12 5 2 0 50% 33-39 +whipper/common/drive.py 37 24 8 0 33% 36-41, 45-51, 55-61, 65-72, 95-98 +whipper/common/encode.py 80 52 12 0 30% 38-39, 42-43, 46-47, 54-57, 60-61, 64-65, 77-78, 81-82, 85-92, 99-100, 103-104, 117-148, 155-160 +whipper/common/mbngs.py 212 52 86 7 76% 40-41, 47, 119-125, 187->186, 245-246, 251-252, 305-306, 313-314, 344-346, 355, 382-392, 412-450 +whipper/common/path.py 22 0 12 0 100% +whipper/common/program.py 380 288 134 6 21% 82->85, 91-93, 101-112, 121-137, 145-147, 152-156, 212, 228-229, 231-233, 234->238, 243, 261-278, 299-411, 423-491, 500-508, 521-537, 541-556, 582-622, 635-658, 661-681, 684-694, 697-705 +whipper/common/renamer.py 103 2 16 1 97% 58->66, 127, 152 +whipper/common/task.py 77 15 14 2 79% 45-50, 84-85, 100, 113-114, 119, 123, 127, 131, 135 whipper/extern/__init__.py 0 0 0 0 100% -whipper/extern/asyncsub.py 112 55 58 11 46% 15-17, 32, 37-38, 47-84, 89-102, 115, 122, 134, 145, 151, 14->15, 35->37, 45->47, 110->113, 114->115, 121->122, 133->134, 139->141, 141->152, 144->145, 148->151 -whipper/extern/freedb.py 90 72 42 0 17% 46, 54, 74-153, 160-199 +whipper/extern/asyncsub.py 112 56 69 16 45% 15-17, 32, 37-38, 47-84, 89-102, 110->113, 115, 122, 125->123, 126->119, 134, 139->141, 141->152, 145-147, 151 +whipper/extern/freedb.py 90 72 42 0 17% 48, 56, 75-154, 171-210 whipper/extern/task/__init__.py 0 0 0 0 100% -whipper/extern/task/task.py 270 115 56 11 53% 53, 59, 78, 86, 152-154, 173-175, 183-199, 217-220, 241-242, 283-284, 287-293, 308-309, 317-319, 328-335, 341-358, 362, 365, 372-389, 400-401, 404-407, 411, 414, 429, 432-434, 450, 462, 508-513, 520-525, 534-542, 545-553, 556-557, 565, 570-572, 52->53, 56->59, 65->67, 151->152, 165->exit, 216->217, 230->232, 235->exit, 497->499, 531->534, 569->570 +whipper/extern/task/task.py 273 115 56 11 53% 52, 58, 64->66, 75, 83, 152-154, 166->exit, 174-176, 185-201, 217-220, 230->232, 235->exit, 241-242, 284-285, 288-294, 309-310, 318-320, 329-336, 340-357, 361, 364, 372-389, 402-403, 406-409, 413, 416, 432, 435-437, 455, 469, 502->504, 513-518, 525-530, 539-547, 550-558, 561-562, 570, 575-577 whipper/image/__init__.py 0 0 0 0 100% -whipper/image/cue.py 91 9 20 3 89% 98, 115-116, 131-133, 158, 186, 204, 97->98, 114->115, 130->131 -whipper/image/image.py 116 93 18 0 17% 49-57, 65-67, 74-107, 121-154, 157-173, 184-214 -whipper/image/table.py 394 18 120 16 93% 240, 499, 578, 663-664, 684-685, 694-697, 748, 794-795, 797-798, 842-843, 848-850, 180->183, 498->499, 532->536, 555->558, 577->578, 585->592, 683->684, 692->698, 693->694, 722->726, 726->721, 747->748, 793->794, 796->797, 841->842, 847->848 -whipper/image/toc.py 203 16 60 10 90% 133, 260-261, 277-280, 338-340, 362-364, 384, 408, 438, 129->133, 211->219, 259->260, 276->277, 286->291, 322->329, 337->338, 361->362, 371->375, 403->408 +whipper/image/cue.py 91 9 20 3 89% 96, 113-114, 129-131, 159, 188, 207 +whipper/image/image.py 123 100 20 0 16% 51-59, 68-70, 79-112, 124-167, 170-186, 195-225 +whipper/image/table.py 383 19 120 16 93% 195->198, 258, 276, 498, 531->535, 554->557, 577, 584->591, 673-674, 695-696, 703->709, 705-708, 736->740, 740->735, 762, 810-811, 813-814, 859-860, 865-867 +whipper/image/toc.py 203 16 60 10 90% 141, 222->230, 271-272, 288-291, 297->302, 333->340, 349-351, 373-375, 382->386, 398, 424, 457 whipper/program/__init__.py 0 0 0 0 100% -whipper/program/arc.py 3 0 0 0 100% -whipper/program/cdparanoia.py 307 179 78 2 39% 48-50, 59-60, 124-126, 198-199, 239-253, 256-306, 309-347, 350-354, 357-393, 447-499, 504-551, 585-588, 591, 598, 606-611, 123->124, 597->598 -whipper/program/cdrdao.py 113 74 32 2 28% 33-58, 80-86, 90-105, 108-137, 140-144, 147-160, 167-170, 180-182, 186-188, 179->180, 185->186 -whipper/program/flac.py 9 5 0 0 44% 12-19 -whipper/program/sox.py 17 4 4 2 71% 18-19, 23-24, 17->18, 22->23 -whipper/program/soxi.py 28 2 4 1 91% 36, 49, 48->49 -whipper/program/utils.py 23 16 2 0 28% 12-17, 25-31, 42-47 +whipper/program/arc.py 3 1 0 0 67% 5 +whipper/program/cdparanoia.py 312 184 84 2 38% 45-47, 54-55, 119-121, 194-195, 233-247, 250-318, 321-359, 362-366, 369-405, 462-515, 520-567, 601-604, 607, 614, 622-627 +whipper/program/cdrdao.py 120 80 34 2 27% 35-64, 84-90, 94-109, 112-141, 144-148, 151-168, 173-176, 184-186, 190-192 +whipper/program/flac.py 9 5 0 0 44% 13-20 +whipper/program/sox.py 17 4 4 2 71% 18-19, 23-24 +whipper/program/soxi.py 28 2 4 1 91% 41, 54 +whipper/program/utils.py 23 16 2 0 28% 10-15, 21-27, 39-44 whipper/result/__init__.py 0 0 0 0 100% -whipper/result/logger.py 144 23 40 16 78% 68, 84-92, 112, 123, 128, 130, 134-135, 143, 202, 240, 244-245, 252-253, 67->68, 83->84, 111->112, 122->123, 127->128, 129->130, 133->134, 142->143, 201->202, 213->217, 217->222, 222->226, 226->230, 234->244, 236->240, 249->252 -whipper/result/result.py 57 13 6 0 70% 115-119, 137, 148-149, 158-165 +whipper/result/logger.py 150 26 44 18 76% 67, 83-91, 111, 122, 127, 129, 133-134, 142, 144, 202, 213->217, 217->222, 222->226, 226->230, 240, 244-245, 250-251, 256-257 +whipper/result/result.py 59 13 6 0 71% 118-122, 137, 148-149, 158-165 ----------------------------------------------------------------------------- -TOTAL 3950 1727 1123 123 53% +TOTAL 4022 1805 1195 124 52% diff --git a/PKG-INFO b/PKG-INFO new file mode 100644 index 00000000..4f52c4b8 --- /dev/null +++ b/PKG-INFO @@ -0,0 +1 @@ +Version: 0.10.0 diff --git a/README.md b/README.md index 33d0bb39..d8c90e8e 100644 --- a/README.md +++ b/README.md @@ -127,8 +127,8 @@ If you are building from a source tarball or checkout, you can choose to use whi Whipper relies on the following packages in order to run correctly and provide all the supported features: - [cd-paranoia](https://github.com/rocky/libcdio-paranoia), for the actual ripping - - To avoid bugs it's advised to use `cd-paranoia` versions ≥ **10.2+0.94+2-2** - - The package named `libcdio-utils`, available on Debian and Ubuntu, is affected by a bug (except for Debian testing/sid where a separate `cd-paranoia` package has been added): it doesn't include the `cd-paranoia` binary (needed by whipper). For more details see: [#888053 (Debian)](https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888053), [#889803 (Debian)](https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=889803) and [#1750264 (Ubuntu)](https://bugs.launchpad.net/ubuntu/+source/libcdio/+bug/1750264). + - To avoid bugs it's advised to use `cd-paranoia` versions ≥ **10.2+0.94+2** + - The package named `libcdio-utils`, available on certain Debian and Ubuntu versions, is affected by a bug: it doesn't include the `cd-paranoia` binary (needed by whipper). Only Debian bullseye (testing) / sid (unstable) and Ubuntu focal (20.04) and later versions have a separate `cd-paranoia` package where the binary is provided. For more details on this issue check the relevant bug reports: [#888053 (Debian)](https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888053), [#889803 (Debian)](https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=889803) and [#1750264 (Ubuntu)](https://bugs.launchpad.net/ubuntu/+source/libcdio/+bug/1750264). - [cdrdao](http://cdrdao.sourceforge.net/), for session, TOC, pre-gap, and ISRC extraction - [GObject Introspection](https://wiki.gnome.org/Projects/GObjectIntrospection), to provide GLib-2.0 methods used by `task.py` - [PyGObject](https://pypi.org/project/PyGObject/), required by `task.py` @@ -136,7 +136,7 @@ Whipper relies on the following packages in order to run correctly and provide a - [mutagen](https://pypi.python.org/pypi/mutagen), for tagging support - [setuptools](https://pypi.python.org/pypi/setuptools), for installation, plugins support - [pycdio](https://pypi.python.org/pypi/pycdio/), for drive identification (required for drive offset and caching behavior to be stored in the configuration file). - - To avoid bugs it's advised to use the most recent `pycdio` version with the corresponding `libcdio` release or, if stuck to old pycdio versions, **0.20**/**0.21** with `libcdio` ≥ **0.90** ≤ **0.94**. All other combinations won't probably work. + - To avoid bugs it's advised to use the most recent `pycdio` version with the corresponding `libcdio` release or, if stuck on old pycdio versions, **0.20**/**0.21** with `libcdio` ≥ **0.90** ≤ **0.94**. All other combinations won't probably work. - [discid](https://pypi.org/project/discid/), for calculating Musicbrainz disc id. - [ruamel.yaml](https://pypi.org/project/ruamel.yaml/), for generating well formed YAML report logfiles - [libsndfile](http://www.mega-nerd.com/libsndfile/), for reading wav files @@ -183,6 +183,8 @@ Install whipper: `python3 setup.py install` Note that, depending on the chosen installation path, this command may require elevated rights. +To build the man pages, follow the instructions in the relevant [README](https://github.com/whipper-team/whipper/blob/develop/man/README.md) which is located in the `man` subfolder. + ## Usage Whipper currently only has a command-line interface called `whipper` which is self-documenting: `whipper -h` gives you the basic instructions. @@ -218,6 +220,8 @@ The simplest way to get started making accurate rips is: If you omit the `-o` argument, whipper will try a long, popularity-sorted list of drive offsets. + Please note that whipper's offset find feature is quite primitive so it may not always achieve its task: in this case using the value listed in [AccurateRip's CD Drive Offset database](http://www.accuraterip.com/driveoffsets.htm) should be enough. + If you can not confirm your drive offset value but wish to set a default regardless, set `read_offset = insert-numeric-value-here` in `whipper.conf`. Offsets confirmed with `whipper offset find` are automatically written to the configuration file. @@ -312,6 +316,8 @@ On a default Debian/Ubuntu installation, the following paths are searched by whi Where `X` stands for the minor version of the Python 3 release available on the system. +Please note that locally installed logger plugins won't be recognized when whipper has been installed through the official Docker image. + ### Official logger plugins I suggest using whipper's default logger unless you've got particular requirements. diff --git a/whipper/command/offset.py b/whipper/command/offset.py index 81752fe4..418a46ba 100644 --- a/whipper/command/offset.py +++ b/whipper/command/offset.py @@ -32,18 +32,18 @@ # see http://www.accuraterip.com/driveoffsets.htm # and misc/offsets.py -OFFSETS = ("+6, +667, +48, +102, +12, +30, +103, +618, +96, +594, " - "+738, +98, -472, +116, +733, +696, +120, +691, +685, " - "+99, +97, +600, +676, +690, +1292, +702, +686, -24, " - "+704, +697, +572, +1182, +688, +91, -491, +145, +689, " - "+564, +708, +86, +355, +79, -496, +679, -1164, 0, " - "+1160, -436, +694, +684, +94, +1194, +106, +681, " - "+117, +692, +943, +92, +680, +678, +682, +1268, +1279, " - "+1473, -582, -54, +674, +687, +1272, +1263, +1508, " - "+675, +534, +740, +122, -489, +974, +976, +1303, " - "+108, +1130, +111, +739, +732, -589, -495, -494, " - "+975, +961, +935, +87, +668, +234, +1776, +138, +1364, " - "+1336, +1262, +1127") +OFFSETS = ("+6, +667, +48, +102, +30, +12, +103, +618, +96, +738, " + "+594, +98, -472, +733, +696, +116, +120, +691, +685, " + "+99, +702, +97, +600, +676, +690, +1292, +686, +697, " + "-24, +704, +572, +1182, +688, -491, +91, +145, +689, " + "+86, +355, +708, +79, +564, -496, +679, -1164, 0, " + "+1160, -436, +684, +694, +1194, +94, +106, +681, " + "+678, +117, +692, +943, +92, +680, +682, +1268, +1279, " + "+1473, -54, +1263, -582, +674, +687, +1272, +1508, " + "-489, +740, +675, +534, +122, +974, +976, +1303, " + "+111, +108, +1130, +975, +87, +739, +732, -589, -495, " + "-494, -12, +961, +935, +699, +668, +234, +1776, +138, " + "+1364, +1336, +1262, +1161, +1127") class Find(BaseCommand):