Java 11 support, release on push to main #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds Java 11 compatibility by replacing Java 17 pattern matching in equals, and updates CI workflows to run releases on pushes to main and build/tests on pull requests to main.
- Revert
instanceofpattern matching inConfig.equalsfor Java 11 support - Trigger
.github/workflows/release.ymlonpushtomain - Run build-and-test workflow on
pull_requesttargetingmain
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/com/mapzen/jpostal/Config.java | Replace Java 17 instanceof pattern matching with classic cast |
| .github/workflows/release.yml | Add push trigger for main branch |
| .github/workflows/build-and-test.yml | Add pull_request trigger for main branch |
Comments suppressed due to low confidence (2)
.github/workflows/release.yml:4
- Indentation of 'push' under 'on:' should match the indentation level used for 'workflow_dispatch' to maintain consistent YAML formatting.
push:
.github/workflows/build-and-test.yml:3
- Ensure 'pull_request' is indented consistently with other event triggers ('push', 'workflow_call') under 'on:' for a valid YAML structure.
pull_request:
jiayuasu
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.