Remove trailing ? when updating URLSearchParams #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests: … Fixes #332.
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 13, 2017
Changes outcome of test added in #6445. Tests for whatwg/url#336.
TimothyGu
approved these changes
Jul 13, 2017
|
@TimothyGu want to review the tests as well? |
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 14, 2017
Changes outcome of test added in #6445. Tests for whatwg/url#336.
4 tasks
Sebmaster
added a commit
to jsdom/whatwg-url
that referenced
this pull request
Jul 28, 2017
If all search params are removed, the question mark is also dropped from the url. Follows whatwg/url#336.
Sebmaster
added a commit
to jsdom/whatwg-url
that referenced
this pull request
Jul 28, 2017
If all search params are removed, the question mark is also dropped from the url. Follows whatwg/url#336.
TimothyGu
added a commit
to nodejs/node
that referenced
this pull request
Aug 1, 2017
PR-URL: #14185 Refs: whatwg/url#336 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to nodejs/node
that referenced
this pull request
Aug 1, 2017
PR-URL: #14185 Refs: whatwg/url#336 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests: …
Fixes #332.
Preview | Diff