-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make URL's origin getter return null for file URLs #506
Comments
Anyone thoughts on this? Or are we ready to give |
Hey @johnathan79717, I noticed web-platform-tests/wpt#36158 which seems to be doing what this issue wants. That seems like a good change, but we should reflect it in the specification if we're going to change the tests. In particular making the API always return "null" and leaving the underlying concept as-is for now is I think what you are pursuing? |
Yes, I wanted to do that but has gotten some pushback on the chromium CL https://chromium-review.googlesource.com/c/chromium/src/+/3734856?tab=comments So I think either we give |
@domenic thoughts on making the getter return " |
I'm very pessimistic about browsers getting there. The amount of anger we get any time file: URLs get less access to new features than the actual web is high (e.g. whatwg/html#8121), and actively taking away the ability to Anyway, I'm ambivalent the proposal at hand. I like the idea of getting at least surface-level interop. I think I would slightly prefer picking some other representative value (e.g. Chromium's " |
I'd rather not introduce a novel origin value. Remember that web content cannot observe the specialness of |
While we don't (want to) govern (yet) if one file URL can fetch another, we can at least govern that the origins file URLs hand out always serialize to "
null
".That is, I would make the getter explicitly check if URL's scheme is "
file
" and if so, return "null
". No need to go through all the trouble of defining a file URL origin I think as navigating to file URLs isn't defined.This affects Safari and Chrome, neither of which return "
null
" yet for any non-special URLs as far as I can tell.cc @achristensen07 @mikewest
The text was updated successfully, but these errors were encountered: