Branch snapshot missing for algorithm-slots branch

[ricea]

#857 links to https://streams.spec.whatwg.org/branch-snapshots/algorithm-slots/ which I think is the correct URL, but it returns a 404.

[domenic]

This appears to be a general problem with the new deploy script. /cc @annevk @foolip. E.g. whatwg/dom#535 also illustrates this problem.

I think the reasoning for removing branch snapshots from the deploy script was that we would use pr-preview instead? /cc @tobie. I'm not sure how to configure pr-preview to not use branch-snapshots. Or maybe this is just a bug in the new deploy script?

[annevk]

I don't think we planned on removing branch snapshots at all. The only thing I remember is that we all acknowledged they're not guaranteed to be stable as branch names can get reused.

[domenic]

Hmm, you're right, I misremembered. The code is still there. I'll try to dig in further...

[foolip]

Looks like https://travis-ci.org/whatwg/streams/builds/303587310 failed, isn't that the explanation?

[domenic]

Ah, right, that makes sense. Then the only issue is that pr-preview links even when builds fail, but I'm not sure that's worth worrying about.

[tobie]

I'm not sure how to configure pr-preview to not use branch-snapshots.

So branch-snapshot usage is special-cased for WHAT WG specs. It's hard-coded, so there are no config options on a per repo basis.

Ah, right, that makes sense. Then the only issue is that pr-preview links even when builds fail, but I'm not sure that's worth worrying about.

I'll be working on adding support to PR-Preview for the HTML spec shortly. I'll see if this issue can be improve while I'm at it.

[tobie]

For info, it's special-cased in the views: https://github.com/tobie/pr-preview/blob/763ed515358f971abd9abbd7f743a4dc56e1bcf9/lib/views/body.js#L56-L62. Which makes it a bit more complicated to check if it has built correctly. There are also race-conditions involved, so fixing this might be pretty difficult.

A better strategy might be to have pr-preview upload the files it creates to a WHAT WG controlled S3 bucket setup as snapshots.whatwg.org (or similar).

[domenic]

I'm leaning toward "everything's working fine and streams just needs to fix its build" currently :)

[annevk]

See whatwg/meta#52 about getting rid of branch-snapshots/ in favor of letting PR Preview manage that always.

[ricea]

Closing as it appears WAI.