Handle exceptions from DetachArrayBuffer #4603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ms2ger
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 9, 2019
|
Can you add a note, or even better an example, explaining when this might throw? I know you can click through to DetachArrayBuffer and find out it has something to do with [[ArrayBufferDetachKey]], but I think it's pretty opaque. |
|
Chrome implementation bug: https://bugs.chromium.org/p/chromium/issues/detail?id=961059 |
|
So, does anyone call https://heycam.github.io/webidl/#dfn-detach? |
littledan
approved these changes
May 9, 2019
There was a problem hiding this comment.
See #4601 (comment) for specification cross-references to understand this fix.
In particular, DetachArrayBuffer() can throw for the ArrayBuffer used as the backing memory in the WebAssembly JS API. This matches the current behavior in Firefox and Safari. Fixes #4601.
|
Added a note |
domenic
approved these changes
May 9, 2019
Ms2ger
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 10, 2019
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 5, 2019
…y ArrayBuffer, a=testonly Automatic update from web-platform-tests Add a test for transferring a WebAssembly ArrayBuffer See <whatwg/html#4603>. -- wpt-commits: e92b4f5a8819d195c5ee5807261cfaa46520dac6 wpt-pr: 16746
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Jun 6, 2019
…y ArrayBuffer, a=testonly Automatic update from web-platform-tests Add a test for transferring a WebAssembly ArrayBuffer See <whatwg/html#4603>. -- wpt-commits: e92b4f5a8819d195c5ee5807261cfaa46520dac6 wpt-pr: 16746
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2019
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…y ArrayBuffer, a=testonly Automatic update from web-platform-tests Add a test for transferring a WebAssembly ArrayBuffer See <whatwg/html#4603>. -- wpt-commits: e92b4f5a8819d195c5ee5807261cfaa46520dac6 wpt-pr: 16746 UltraBlame original commit: e261df73282723d85a2e7dc366f73a11cd8ac6c5
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…y ArrayBuffer, a=testonly Automatic update from web-platform-tests Add a test for transferring a WebAssembly ArrayBuffer See <whatwg/html#4603>. -- wpt-commits: e92b4f5a8819d195c5ee5807261cfaa46520dac6 wpt-pr: 16746 UltraBlame original commit: e261df73282723d85a2e7dc366f73a11cd8ac6c5
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…y ArrayBuffer, a=testonly Automatic update from web-platform-tests Add a test for transferring a WebAssembly ArrayBuffer See <whatwg/html#4603>. -- wpt-commits: e92b4f5a8819d195c5ee5807261cfaa46520dac6 wpt-pr: 16746 UltraBlame original commit: e261df73282723d85a2e7dc366f73a11cd8ac6c5
3 tasks
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
…y ArrayBuffer, a=testonly Automatic update from web-platform-tests Add a test for transferring a WebAssembly ArrayBuffer See <whatwg/html#4603>. -- wpt-commits: e92b4f5a8819d195c5ee5807261cfaa46520dac6 wpt-pr: 16746
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, DetachArrayBuffer() can throw for the ArrayBuffer used as the
backing memory in the WebAssembly JS API.
This matches the current behavior in Firefox and Safari.
Fixes #4601.
(See WHATWG Working Mode: Changes for more details.)
/references.html ( diff )
/structured-data.html ( diff )