Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: align with JavaScript spec conventions on records #8364

Open
domenic opened this issue Oct 7, 2022 · 3 comments
Open

Editorial: align with JavaScript spec conventions on records #8364

domenic opened this issue Oct 7, 2022 · 3 comments
Labels
good first issue Ideal for someone new to a WHATWG standard or software project integration Better coordination across standards needed

Comments

@domenic
Copy link
Member

domenic commented Oct 7, 2022

The latest work on the JS spec seems to say things like "Let completion be Completion Record { [[Type]]: ..., [[Value]]: ..., [[Target]]: ... }."

It looks like we sometimes use Completion { with no link (should be Completion Record { with a link) and Property Descriptor{ with a link (should have a space before {).

For "untyped" records, we mostly don't have any prefix. Sometimes we have Record { linked, sometimes we have Record { unlinked, most times we just use {. Some of these these are just omitting Property Descriptor {, which we should fix. But I don't think we should necessarily add Record { in front of all of them, even though the JS spec does. It's verbose and many of these could probably be converted to Infra maps anyway. (#8363) I'm inclined to leave most of them as-is, or maybe just remove the Record prefix.

@domenic domenic added good first issue Ideal for someone new to a WHATWG standard or software project integration Better coordination across standards needed labels Oct 7, 2022
@YASHWANTHKESAGONI

This comment was marked as spam.

@rajbelwal

This comment was marked as spam.

@git-devisha

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Ideal for someone new to a WHATWG standard or software project integration Better coordination across standards needed
Development

No branches or pull requests

5 participants
@domenic @rajbelwal @YASHWANTHKESAGONI @git-devisha and others