Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fire input event for radio buttons or checkboxes #601

Closed
zcorpan opened this issue Feb 2, 2016 · 9 comments
Closed

Don't fire input event for radio buttons or checkboxes #601

zcorpan opened this issue Feb 2, 2016 · 9 comments
Labels
compat Standard is not web compatible or proprietary feature needs standardizing normative change

Comments

@zcorpan
Copy link
Member

zcorpan commented Feb 2, 2016

From web-platform-tests/wpt#2539

Tests:
radio button http://software.hixie.ch/utilities/js/live-dom-viewer/saved/3859
checkbox http://software.hixie.ch/utilities/js/live-dom-viewer/saved/3860

It seems Chromium/WebKit/Gecko don't fire input event. (Note that "input 1" does not appear in the log.) Haven't tested Edge.

cc @cvrebert

@zcorpan zcorpan added normative change compat Standard is not web compatible or proprietary feature needs standardizing labels Feb 2, 2016
@zcorpan
Copy link
Member Author

zcorpan commented Feb 2, 2016

(Should probably test all input types to get a bigger picture.)

@cvrebert
Copy link
Member

cvrebert commented Feb 2, 2016

See the Notes (and bugs linked therein) of http://caniuse.com/#feat=input-event

To be clear, the currently-spec'd behavior of input is sensible and I like it personally.

@cvrebert
Copy link
Member

cvrebert commented Feb 2, 2016

To summarize:

Fires input events? <select> <input type="checkbox">
&
<input type="radio">
<input type="file">
Chrome ✅ Yes ❌ No: https://crbug.com/534245 ❌ No: https://crbug.com/534245
Safari ✅ Yes ❌ No: http://webkit.org/b/149398 ❌ No: http://webkit.org/b/149398
Firefox ❌ No: http://bugzil.la/1024350 ❌ No: http://bugzil.la/1206616 ❌ No: http://bugzil.la/1206616
Edge ❌ No: bug 1816207 ❌ No: bug 1883692 & UserVoice 10182111 ✅ Yes
IE11 ❌ No ❌ No Probably Yes

@zcorpan
Copy link
Member Author

zcorpan commented Feb 2, 2016

Thank you for the summary and the links! Very helpful!

@cvrebert
Copy link
Member

@zcorpan So what's the next step here?

@zcorpan
Copy link
Member Author

zcorpan commented Feb 16, 2016

I think we should leave the spec as is and hope browsers implement input events everywhere. In a year or two we can revisit this if browsers still haven't implemented.

Next step is probably to cc someone who could fix the bug for each bug. I can do that for Chromium.

@zcorpan zcorpan closed this as completed Feb 16, 2016
@annevk
Copy link
Member

annevk commented Feb 16, 2016

@miketaylr @RByers some of the above may exhibit itself as webcompat issues. ^^

@miketaylr
Copy link
Member

Thanks @annevk. I haven't found any yet, but this Gecko bug feels related: events fired on <option> don't bubble up to <select> https://bugzilla.mozilla.org/show_bug.cgi?id=1090602 (which we WONTFIX'd because platform/browser behavior is all over the place. See comment 27 and 34 and then test multi/inline select and weep because it gets more inconsistent).

@RByers
Copy link

RByers commented Feb 25, 2016

@annevk, thanks. My team is working on input events, so I've added this bug to our TODO list. Do let me know if a webcompat issue surfaces in practice and we can bump the priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat Standard is not web compatible or proprietary feature needs standardizing normative change
Development

No branches or pull requests

5 participants