-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use align-content for form control centering instead of html "magic" #10396
Comments
Seems like a decent idea. |
The button layout magic covers more than safe centering, do you intend to keep those as-is or try to remove them also? |
This comment was marked as spam.
This comment was marked as spam.
@zcorpan - Blink M126 just rolled out with block-layout buttons enabled by default. And we didn't include the anonymous block described by that part of the spec. (I suspect this was added just for centering purposes, but you really don't need it). So I intend to remove that also. I'll prepare a PR so we can see what this looks like. |
@bfgeek is there an easy way that I can opt in to the new behavior, in my local Chrome 127 "dev channel" installation? (You mentioned enabled by default in 126, but I don't think I'm seeing the behavior, if I understand the proposal correctly. I did also try "Experimental Web Platform Features:enabled" in RE webcompat risk: if I'm understanding correctly, this proposal does mean that buttons with (There's no difference for |
My understanding is that the way blink implemented this doesn't affect grid or flex, which is a bit unfortunate because it's replacing some magic for another. @bfgeek is the idea to eventually apply this to all buttons as proposed in your comment? Or something else? |
What is the issue with the HTML Standard?
Now that align-content is more widely implemented we can switch the control centering magic to just use align-content instead.
We are starting to get some bug reports that web developers would desire to control this behaviour in form controls, e.g.
https://issues.chromium.org/issues/344643705
This would basically mean adding something like:
And removing all the special text for the centering behaviour in the form control part of the spec.
There is a small compat risk, but we'd be happy to take on that risk.
cc/ @dholbert @emilio
The text was updated successfully, but these errors were encountered: