Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"aborted flag" for non-network errors #938

Open
annevk opened this issue Sep 14, 2019 · 1 comment
Open

"aborted flag" for non-network errors #938

annevk opened this issue Sep 14, 2019 · 1 comment

Comments

@annevk
Copy link
Member

annevk commented Sep 14, 2019

It looks like we sometimes set the "aborted flag" on responses that are not network errors. I guess that should be possible to account for late aborted fetches. We might want to point this out more explicitly?

https://fetch.spec.whatwg.org/#dom-global-fetch only branches on "aborted flag" and not "aborted network error". Since setting the aborted flag is not queued as a task it seems that it's possible for a race condition there to cause something to throw while there was actually a response. At the very least I think we should branch on "aborted network error" in "To process response for response".

cc @jakearchibald

@annevk
Copy link
Member Author

annevk commented Sep 26, 2022

@nidhijaju perhaps this is something you can look at as well? It might not be too hard to fix at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant