Skip to content

Allow SharedArrayBuffer #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 9, 2019
Merged

Allow SharedArrayBuffer #182

merged 7 commits into from
Oct 9, 2019

Conversation

annevk
Copy link
Member

@annevk annevk commented Aug 16, 2019 •
edited by pr-preview bot
Loading

Tests: ...

Fixes #172.

Preview | Diff

@annevk
Copy link
Member Author

annevk commented Aug 16, 2019

I'm not quite sure what the note would say...

@annevk annevk mentioned this pull request Aug 16, 2019
Closed
@hsivonen
Copy link
Member

I'm not quite sure what the note would say...

Maybe something like:

"Note: The memory exposed by SharedArrayBuffers does not adhere to data race freedom properties required by the memory model of programming languages typically used for implementing user agents. When implementing the SharedArrayBuffer case, take care to use the appropriate special facilities when accessing SharedArrayBuffer content."

@Bnaya
Copy link

Bnaya commented Oct 4, 2019

Possible tests:
web-platform-tests/wpt#19531

@annevk
Copy link
Member Author

annevk commented Oct 8, 2019

@ricea so https://encoding.spec.whatwg.org/#decode-and-enqueue-a-chunk would have to be updated to convert to a [AllowShared] BufferSource? And until we have bring-your-own-buffer streams no other updates would be needed? If that's all, we should probably tackle that as part of this PR.

@ricea
Copy link
Collaborator

ricea commented Oct 8, 2019

@ricea so https://encoding.spec.whatwg.org/#decode-and-enqueue-a-chunk would have to be updated to convert to a [AllowShared] BufferSource? And until we have bring-your-own-buffer streams no other updates would be needed? If that's all, we should probably tackle that as part of this PR.

Exactly, yes.

ricea
ricea reviewed Oct 8, 2019
View reviewed changes
ricea
ricea reviewed Oct 8, 2019
View reviewed changes
@ricea
Copy link
Collaborator

ricea commented Oct 8, 2019

TextDecoderStream changes look great.

annevk
annevk commented Oct 8, 2019
View reviewed changes
annevk pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 9, 2019
@Bnaya @annevk
Encoding: TextEncoder/TextDecoder SharedArrayBuffer tests
a910ad1 
For whatwg/encoding#182.
@annevk annevk merged commit c1ad763 into master Oct 9, 2019
@annevk annevk deleted the annevk/sab branch October 9, 2019 09:59
@annevk
Copy link
Member Author

annevk commented Oct 9, 2019

Thanks @hsivonen and @ricea for your help with this PR and thanks a ton to @Bnaya for taking care of the tests, much appreciated!

Bugs:

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 24, 2019
@Bnaya @jgraham
Bug 1586437 [wpt PR 19531] - TextEncoder/TextDecoder SharedArrayBuffe…
201ff7a 
…r tests, a=testonly

Automatic update from web-platform-tests
Encoding: TextEncoder/TextDecoder SharedArrayBuffer tests

For whatwg/encoding#182.
--

wpt-commits: a910ad1791d138e10558c3ab0db1a29c6a8c5058
wpt-pr: 19531
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Oct 24, 2019
@Bnaya @jgraham
Bug 1586437 [wpt PR 19531] - TextEncoder/TextDecoder SharedArrayBuffe…
a04a396 
…r tests, a=testonly

Automatic update from web-platform-tests
Encoding: TextEncoder/TextDecoder SharedArrayBuffer tests

For whatwg/encoding#182.
--

wpt-commits: a910ad1791d138e10558c3ab0db1a29c6a8c5058
wpt-pr: 19531
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 27, 2019
@marco-c
Bug 1586437 [wpt PR 19531] - TextEncoder/TextDecoder SharedArrayBuffe…
6fc531f 
…r tests, a=testonly

Automatic update from web-platform-tests
Encoding: TextEncoder/TextDecoder SharedArrayBuffer tests

For whatwg/encoding#182.
--

wpt-commits: a910ad1791d138e10558c3ab0db1a29c6a8c5058
wpt-pr: 19531

UltraBlame original commit: d1e1230935645114696bafbb82c5ee05c5dcfad7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 27, 2019
@marco-c
Bug 1586437 [wpt PR 19531] - TextEncoder/TextDecoder SharedArrayBuffe…
e6689dc 
…r tests, a=testonly

Automatic update from web-platform-tests
Encoding: TextEncoder/TextDecoder SharedArrayBuffer tests

For whatwg/encoding#182.
--

wpt-commits: a910ad1791d138e10558c3ab0db1a29c6a8c5058
wpt-pr: 19531

UltraBlame original commit: d1e1230935645114696bafbb82c5ee05c5dcfad7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 27, 2019
@marco-c
Bug 1586437 [wpt PR 19531] - TextEncoder/TextDecoder SharedArrayBuffe…
88058e7 
…r tests, a=testonly

Automatic update from web-platform-tests
Encoding: TextEncoder/TextDecoder SharedArrayBuffer tests

For whatwg/encoding#182.
--

wpt-commits: a910ad1791d138e10558c3ab0db1a29c6a8c5058
wpt-pr: 19531

UltraBlame original commit: d1e1230935645114696bafbb82c5ee05c5dcfad7
bhearsum pushed a commit to mozilla-releng/staging-firefox that referenced this pull request May 1, 2025
@Bnaya @jgraham
Bug 1586437 [wpt PR 19531] - TextEncoder/TextDecoder SharedArrayBuffe…
7926ab8 
…r tests, a=testonly

Automatic update from web-platform-tests
Encoding: TextEncoder/TextDecoder SharedArrayBuffer tests

For whatwg/encoding#182.
--

wpt-commits: a910ad1791d138e10558c3ab0db1a29c6a8c5058
wpt-pr: 19531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bnaya Bnaya Bnaya left review comments

@ricea ricea ricea left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make decode() and encodeInto() accept SharedArrayBuffer-backed views
4 participants
@annevk @hsivonen @Bnaya @ricea