-
Notifications
You must be signed in to change notification settings - Fork 295
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Close #123: remove feature detection from add() and add supports()
This change replaces the feature detection method for DOMTokenLists: * It removes references to "validation steps" from add(), toggle(), replace() and object creation. * It adds supports() as discussed. * When associated attribute has no supported tokens, TypeError is thrown (by "validation steps").
- Loading branch information
Showing
2 changed files
with
52 additions
and
50 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
ff4f0e8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoavweiss
supports()
takes single token or we can pass more than one token? I see...
in prose (https://dom.spec.whatwg.org/#dom-domtokenlist-supports) but not in IDL.ff4f0e8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's supposed to take a single token. I no longer see that, so I'm assuming it was fixed in the mean time?
ff4f0e8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I fixed this in a97debc.