diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 90351b4f..39ba78a6 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -52,10 +52,10 @@ check-simulate: crate: simulate clippy: - image: rustlang/rust:nightly + image: rust script: - rustup component add clippy - - cargo clippy + - cargo clippy --all-targets --features strict # Unfortunately testing can't happen in CI right now because we require Windows. .test: diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 5bb6f226..c592b2d7 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -72,7 +72,7 @@ repos: name: clippy language: system files: '[.]rs$' - entry: cargo +nightly clippy + entry: cargo clippy --all-targets --features strict pass_filenames: false - id: test diff --git a/brain-test-data/build.rs b/brain-test-data/build.rs index ce2cb064..a1e069a9 100644 --- a/brain-test-data/build.rs +++ b/brain-test-data/build.rs @@ -1,6 +1,6 @@ #![warn(future_incompatible, rust_2018_compatibility, rust_2018_idioms, unused)] #![cfg_attr(feature = "strict", deny(warnings))] -#![deny(clippy::all)] +#![warn(clippy::all)] use std::{ env, diff --git a/brain-test-data/src/lib.rs b/brain-test-data/src/lib.rs index 4d477497..ab9ca75a 100644 --- a/brain-test-data/src/lib.rs +++ b/brain-test-data/src/lib.rs @@ -1,6 +1,6 @@ #![warn(future_incompatible, rust_2018_compatibility, rust_2018_idioms, unused)] #![cfg_attr(feature = "strict", deny(warnings))] -#![deny(clippy::all)] +#![warn(clippy::all)] #![allow(clippy::unreadable_literal)] pub use crate::models::OneVOneScenario; diff --git a/brain/src/lib.rs b/brain/src/lib.rs index 0326e56f..f62c4b74 100644 --- a/brain/src/lib.rs +++ b/brain/src/lib.rs @@ -1,6 +1,6 @@ #![warn(future_incompatible, rust_2018_compatibility, rust_2018_idioms, unused)] #![cfg_attr(feature = "strict", deny(warnings))] -#![deny(clippy::all)] +#![warn(clippy::all)] #![allow(clippy::unreadable_literal)] pub use crate::{brain::Brain, eeg::EEG}; diff --git a/collect/src/lib.rs b/collect/src/lib.rs index 9e25cb0f..7f277906 100644 --- a/collect/src/lib.rs +++ b/collect/src/lib.rs @@ -1,6 +1,6 @@ #![warn(future_incompatible, rust_2018_compatibility, rust_2018_idioms, unused)] #![cfg_attr(feature = "strict", deny(warnings))] -#![deny(clippy::all)] +#![warn(clippy::all)] pub use crate::{ collector::Collector, diff --git a/collect/src/main.rs b/collect/src/main.rs index 89002dcf..24dcfd39 100644 --- a/collect/src/main.rs +++ b/collect/src/main.rs @@ -1,6 +1,6 @@ #![warn(future_incompatible, rust_2018_compatibility, rust_2018_idioms, unused)] #![cfg_attr(feature = "strict", deny(warnings))] -#![deny(clippy::all)] +#![warn(clippy::all)] use crate::{ collector::Collector, diff --git a/common/src/lib.rs b/common/src/lib.rs index c4163e91..047f3fa3 100644 --- a/common/src/lib.rs +++ b/common/src/lib.rs @@ -1,6 +1,6 @@ #![warn(future_incompatible, rust_2018_compatibility, rust_2018_idioms, unused)] #![cfg_attr(feature = "strict", deny(warnings))] -#![deny(clippy::all)] +#![warn(clippy::all)] pub use crate::{ ext::ExtendRLBot, diff --git a/dom/src/lib.rs b/dom/src/lib.rs index ffdf5920..8304c3b6 100644 --- a/dom/src/lib.rs +++ b/dom/src/lib.rs @@ -6,7 +6,7 @@ Rust translation of some code from DomNomNom's [RocketBot]. #![warn(future_incompatible, rust_2018_compatibility, rust_2018_idioms, unused)] #![cfg_attr(feature = "strict", deny(warnings))] -#![deny(clippy::all)] +#![warn(clippy::all)] pub use crate::{student_agents::get_pitch_yaw_roll, vector_math::to_rotation_matrix}; diff --git a/oven/build.rs b/oven/build.rs index b71db664..53a253a3 100644 --- a/oven/build.rs +++ b/oven/build.rs @@ -1,6 +1,6 @@ #![warn(future_incompatible, rust_2018_compatibility, rust_2018_idioms, unused)] #![cfg_attr(feature = "strict", deny(warnings))] -#![deny(clippy::all)] +#![warn(clippy::all)] use common::prelude::*; use nalgebra::{UnitComplex, UnitQuaternion}; diff --git a/oven/src/lib.rs b/oven/src/lib.rs index 8bbe895e..83d5f6d1 100644 --- a/oven/src/lib.rs +++ b/oven/src/lib.rs @@ -1,6 +1,6 @@ #![warn(future_incompatible, rust_2018_compatibility, rust_2018_idioms, unused)] #![cfg_attr(feature = "strict", deny(warnings))] -#![deny(clippy::all)] +#![warn(clippy::all)] #![allow(clippy::unreadable_literal)] pub mod data; diff --git a/play/src/main.rs b/play/src/main.rs index 8122745d..4b08df1b 100644 --- a/play/src/main.rs +++ b/play/src/main.rs @@ -1,6 +1,6 @@ #![warn(future_incompatible, rust_2018_compatibility, rust_2018_idioms, unused)] #![cfg_attr(feature = "strict", deny(warnings))] -#![deny(clippy::all)] +#![warn(clippy::all)] use brain::{Brain, EEG}; use chrono::Local; diff --git a/simulate/src/lib.rs b/simulate/src/lib.rs index b53b860a..1c41c0dd 100644 --- a/simulate/src/lib.rs +++ b/simulate/src/lib.rs @@ -1,6 +1,6 @@ #![warn(future_incompatible, rust_2018_compatibility, rust_2018_idioms, unused)] #![cfg_attr(feature = "strict", deny(warnings))] -#![deny(clippy::all)] +#![warn(clippy::all)] #![allow(clippy::unreadable_literal)] pub use crate::{