fix: complete iOS scroll lock cleanup and body style restoration #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix issue where top: 0 remained on body element after bottom sheet closes on iOS - Improve style restoration logic to properly remove inline styles when no original value existed - Add explicit handling for externally modified properties to prevent style conflicts - Ensures clean body state restoration in all scenarios
|
🎉 This PR is included in version 4.0.0-beta.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
top: 0style remained on body element after bottom sheet closes on iOSTechnical Details
This commit addresses a subtle bug in the scroll lock restoration logic:
Problem: After closing bottom sheet on iOS,
body.style.topwould remain set to0pxinstead of being properly removed.Root Cause: The restoration logic was not properly distinguishing between properties that should be removed vs. restored when no original inline style existed.
Solution:
originalInlineValue === '', we now properly remove the property entirely usingremoveProperty()Test Plan
This completes the scroll lock conflict resolution system, ensuring robust cleanup in all scenarios.