build issue with harfbuzz #1
Comments
|
https://docs.rs/harfbuzz-sys/0.1.15/harfbuzz_sys/ aka this crate |
|
Ideally, yes, but I need it to support freetype when it builds its bundled lib, and this prevents it from doing that: https://github.com/servo/rust-harfbuzz/blob/master/harfbuzz-sys/makefile.cargo#L36 |
|
e7d9902 is the commit where I switched away from it. In the longer run I'd like to not have my own thing for this, but its an effective short term way to make sure that we get a new enough harfbuzz on travis and other linuxes. |
|
I finally figured out what I was doing wrong forgot to clone the modules
…On Feb 22, 2018 12:11 PM, "Wez Furlong" ***@***.***> wrote:
e7d9902
<e7d9902>
is the commit where I switched away from it. In the longer run I'd like to
not have my own thing for this, but its an effective short term way to make
sure that we get a new enough harfbuzz on travis and other linuxes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFD6iAA8raOSsoOMsoSccxPcoYSoFGsWks5tXZ-tgaJpZM4SPcXB>
.
|
|
Compiling term v0.1.0 (file:///home/solaraquarion/wezterm/term) error: Could not compile |
|
Yeah, I saw this today on someone else's Fedora machine and on another person's Arch distro. I'll fix this. |
This will likely break travis; I'll follow up with something to help with that. Refs: #1
|
Amazingly, I got the travis build bits right on the first iteration(!) so I think you should be good to go with this now; please let me know if it works for you! |
wez
changed the title
|
This is good to go now |
I was running `hg log --config pager.pager=sp` and pressing space without
releasing it. After about 10k lines sp appears to deadlock. It seems sp uses a
single thread for both reading terminal events and sending wake events and it
sends too many wake events without reading the events.
Failing to write to the wake pipe due to EWOULDBLOCK does not seem to be a
problem - there are enough events in the pipe to wake up the other side.
Therefore let's just make wake_pipe_write nonblocking and treat EWOULDBLOCK as
a success.
Context: The stuck thread looks like:
#0 0x00007f32671ee237 in write () from /usr/lib/libc.so.6
wez#1 0x000055c466022823 in std::sys::unix::fd::FileDesc::write () at src/libstd/sys/unix/fd.rs:96
wez#2 std::sys::unix::net::Socket::write () at src/libstd/sys/unix/net.rs:276
wez#3 <&std::sys::unix::ext::net::UnixStream as std::io::Write>::write ()
at src/libstd/sys/unix/ext/net.rs:597
wez#4 <std::sys::unix::ext::net::UnixStream as std::io::Write>::write ()
at src/libstd/sys/unix/ext/net.rs:582
wez#5 0x000055c465d010a6 in termwiz::terminal::unix::UnixTerminalWaker::wake (self=0x7ffe6bd32de0)
at /home/quark/.cargo/git/checkouts/wezterm-6425bab852909cc8/ef1b836/termwiz/src/terminal/unix.rs:278
wez#6 0x000055c465a6c64b in streampager::event::EventSender::send_unique (self=0x7ffe6bd32dd0, event=...,
unique=0x7ffe6bd32de8) at src/event.rs:66
wez#7 0x000055c465a7e65a in streampager::display::start (term=..., term_caps=..., events=..., files=...,
error_files=..., progress=..., mode=streampager::config::FullScreenMode::Auto) at src/display.rs:295
wez#8 0x000055c465a453a7 in streampager::Pager::run (self=...) at src/lib.rs:171
wez#9 0x000055c465a0aced in sp::open_files (args=...) at src/bin/sp/main.rs:170
wez#10 0x000055c465a08e4f in sp::main () at src/bin/sp/main.rs:25
I was running `hg log --config pager.pager=sp` and pressing space without
releasing it. After about 10k lines sp appears to deadlock. It seems sp uses a
single thread for both reading terminal events and sending wake events and it
sends too many wake events without reading the events.
Failing to write to the wake pipe due to EWOULDBLOCK does not seem to be a
problem - there are enough events in the pipe to wake up the other side.
Therefore let's just make wake_pipe_write nonblocking and treat EWOULDBLOCK as
a success.
Context: The stuck thread looks like:
#0 0x00007f32671ee237 in write () from /usr/lib/libc.so.6
#1 0x000055c466022823 in std::sys::unix::fd::FileDesc::write () at src/libstd/sys/unix/fd.rs:96
#2 std::sys::unix::net::Socket::write () at src/libstd/sys/unix/net.rs:276
#3 <&std::sys::unix::ext::net::UnixStream as std::io::Write>::write ()
at src/libstd/sys/unix/ext/net.rs:597
#4 <std::sys::unix::ext::net::UnixStream as std::io::Write>::write ()
at src/libstd/sys/unix/ext/net.rs:582
#5 0x000055c465d010a6 in termwiz::terminal::unix::UnixTerminalWaker::wake (self=0x7ffe6bd32de0)
at /home/quark/.cargo/git/checkouts/wezterm-6425bab852909cc8/ef1b836/termwiz/src/terminal/unix.rs:278
#6 0x000055c465a6c64b in streampager::event::EventSender::send_unique (self=0x7ffe6bd32dd0, event=...,
unique=0x7ffe6bd32de8) at src/event.rs:66
#7 0x000055c465a7e65a in streampager::display::start (term=..., term_caps=..., events=..., files=...,
error_files=..., progress=..., mode=streampager::config::FullScreenMode::Auto) at src/display.rs:295
#8 0x000055c465a453a7 in streampager::Pager::run (self=...) at src/lib.rs:171
#9 0x000055c465a0aced in sp::open_files (args=...) at src/bin/sp/main.rs:170
#10 0x000055c465a08e4f in sp::main () at src/bin/sp/main.rs:25
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
https://github.com/servo/rust-harfbuzz
The text was updated successfully, but these errors were encountered: