-
Notifications
You must be signed in to change notification settings - Fork 5
feat(select): Add toggle button and remove force open in editor option (WW-3773) #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…that caused issues on dark theme
…that caused issues on dark theme (#124) Co-authored-by: Alexy Carlier <alexy.carlier@gmail.com>
5c5e7f5
to
b42207e
Compare
5685edd
to
57e4bc4
Compare
57e4bc4
to
affa35c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new toggle button functionality in the editor panel by replacing the deprecated “Force open in editor” option with a toggle mechanism.
- Replaces 'forceOpenInEditor' with 'toggleSelect' in configuration
- Refactors the state management in wwElement_Select.vue from a computed property to a ref
- Adjusts button actions and labels to support the toggle functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
ww-config.js | Updated settings order and property definitions for the new toggle option |
src/wwElement_Select.vue | Replaced computed property with a ref and added toggle method implementation |
Comments suppressed due to low confidence (1)
ww-config.js:238
- [nitpick] The property 'toggleSelect' is configured with an action 'toggleForceOpenInEditor' and a simple 'Toggle' label, which might be ambiguous. Consider renaming the property or aligning the action name and label to clearly indicate its functionality.
toggleSelect: {
this.resetLastTriggerComponentAction(); | ||
this.resetSearch(); | ||
}, | ||
toggleForceOpenInEditor() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching from a computed property to a ref for 'forceOpenInEditor' necessitates proper reactive handling. Since refs require using '.value' to update their state, ensure that this ref is correctly integrated (for example, by either returning it via setup or declaring it in data) so that toggling works as intended.
Copilot uses AI. Check for mistakes.
Summary