video "source" elements have inappropriate mime-types

[mozai]

forum/Sources/Subs.php, lines 1629-1635:

+   +   +   +   +   +   $tag['content'] = "-
+   +   +   +   +   +   <video width='768' height='auto' style='max-width: 100%' controls>-
+   +   +   +   +   +   <source src='{$data}' type='video/mp4'>-
+   +   +   +   +   +   <source src='{$data}' type='video/webm'>-
+   +   +   +   +   +   <source src='{$data}' type='video/ogg'>-
+   +   +   +   +   +   Your browser does not support the video tag.-
+   +   +   +   +   +   </video>";-

Same source with multiple mime-types confuses web browsers, and a webbrowser could pick the last for an MPEG4 file, or the first for an Ogg Vorbis file.

Maybe try

$minortype = pathinfo($data, PATHINFO_EXTENSION);
$minortype = ($minortype == "ogv") ? "ogg" : $minortype;
$tag['content'] = "<video width='768' height='auto' style='max-width: 100%' controls>
<source src='{$data}' type='video/{$minortype}'/>Your browser does not support the video tag</video>
"

Using the filename to detect the mime-type is flimsy, but better than what's currently used. Real mime-type detecting requires downloading the first ~4kB of the file and scrutinizing the bytes, and even then it's not guaranteed (some file formats put their catalog info at the tail-end of the file... smh).