Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gulpfile to build and test sequentially #36

Open
itsrachelfish opened this issue Oct 8, 2016 · 0 comments
Open

Update gulpfile to build and test sequentially #36

itsrachelfish opened this issue Oct 8, 2016 · 0 comments
Labels

Comments

@itsrachelfish
Copy link
Member

The current gulp configuration builds the main basic.js file and basic.min.js file simultaneously, so it's possible for basic.min.js to be generated from an older version of basic.js before the new version is finished saving to disk.

During development if you have gulp running and save frequently this isn't as much of an issue, but I noticed it happened while merging a pull request.

Also the tests in gulp should only be run after the new version of basic.js has been generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant