Skip to content

Self camera check #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 845 commits into
base: dev
Choose a base branch
from
Open

Self camera check #22

wants to merge 845 commits into from

Conversation

rekire
Copy link

@rekire rekire commented Nov 2, 2022

This PR includes the changes of #19 and checks if the Camera Permission is declared in the manifest if not the dialog to "take a picture" is skipped and the file chooser is directly opened.

If you want to use my fork try this in your pubspec.yaml:

dependencies:
  # ...
  flutter_webview_pro:
    git:
      url: https://github.com/rekire/flutter-plugins-fork.git
      ref: 9713d3b589e8db565d2046bf8a11aee73af33aca #self_camera_check
      path: packages/webview_flutter/webview_flutter

dependency_overrides:
  webview_pro_android:
    git:
      url: https://github.com/rekire/flutter-plugins-fork.git
      ref: 9713d3b589e8db565d2046bf8a11aee73af33aca #self_camera_check
      path: packages/webview_flutter/webview_flutter_android

GaryQian and others added 30 commits August 11, 2022 11:06
…gle_maps_flutter/google_maps_flutter_android/android (flutter#6266)
…s/quick_actions/quick_actions_android/example/android/app (flutter#6261)
Apply new format rules to some dart files.

This fixes the flutter -> plugin roll
…deo_player/video_player_android/example/android/app (flutter#6250)
…uick_actions/quick_actions_android/example/android/app (flutter#6258)
…pp_purchase/in_app_purchase_android/example/android/app (flutter#6254)
* 7d1323c Updating expiring cirrus key. (flutter/flutter#109461)

* a85902a Roll Flutter Engine from de118a55ade0 to c354e0e04cea (2 revisions) (flutter/flutter#109462)

* 28de3d4 Roll Flutter Engine from c354e0e04cea to d1b18b5d6811 (1 revision) (flutter/flutter#109466)

* a624cb7 Keep `dirty` manipulations private to `Element` base class (flutter/flutter#109401)

* dce82f7 Remove deprecated Ruby File.exists? in helper script (flutter/flutter#109428)

* 7887ca5 Revert "Keep `dirty` manipulations private to `Element` base class (#109401)" (flutter/flutter#109481)

* 237a298 Roll Flutter Engine from d1b18b5d6811 to a2f3bd58ce73 (1 revision) (flutter/flutter#109472)

* fe2fc8d Single tap on the previous selection should toggle the toolbar on iOS… (flutter/flutter#108913)

* 696c6fb Roll Flutter Engine from a2f3bd58ce73 to fb19700742c3 (6 revisions) (flutter/flutter#109482)

* 17bc0ce Roll Flutter Engine from fb19700742c3 to 2180e62f6c7e (1 revision) (flutter/flutter#109483)

* 4265015 Roll Flutter Engine from 2180e62f6c7e to cd1a1cb757f5 (1 revision) (flutter/flutter#109488)

* c142dd3 Roll Flutter Engine from cd1a1cb757f5 to 5cc5c5f04f0a (1 revision) (flutter/flutter#109490)

* 8a55c36 Roll Flutter Engine from 5cc5c5f04f0a to 18dca3de7496 (2 revisions) (flutter/flutter#109493)

* d50c5b1 Roll Flutter Engine from 18dca3de7496 to 83771593cb55 (1 revision) (flutter/flutter#109505)

* 97901da Cleaner test.dart output. (flutter/flutter#109206)

* fb3c8ea Roll Flutter Engine from 83771593cb55 to f49a617535af (1 revision) (flutter/flutter#109509)

* 5fcd9c2 Update README.md (flutter/flutter#109506)

* 4dd7065 Add onOpened callback to PopupMenuButton (flutter/flutter#103753)

* ed3238e Roll Flutter Engine from f49a617535af to cc9f4c63b7e5 (1 revision) (flutter/flutter#109518)

* 8b1ca3f Roll Flutter Engine from cc9f4c63b7e5 to 4656c2f46cad (1 revision) (flutter/flutter#109524)

* 20ffb32 Roll Flutter Engine from 4656c2f46cad to 16fb19e72f88 (1 revision) (flutter/flutter#109526)

* 087750f Roll Flutter Engine from 16fb19e72f88 to 9c3c233e2639 (1 revision) (flutter/flutter#109532)

* 4aba124 Roll Flutter Engine from 9c3c233e2639 to f0c3829e90ce (1 revision) (flutter/flutter#109536)

* 2bce108 Roll Plugins from 9fb7654 to 094f1c3 (7 revisions) (flutter/flutter#109543)

* 97d9a2f Roll Flutter Engine from f0c3829e90ce to 8c019cdd446f (2 revisions) (flutter/flutter#109548)

* 458d618 Roll Flutter Engine from 8c019cdd446f to 198b0051a5a2 (1 revision) (flutter/flutter#109552)

* c873c21 Roll Flutter Engine from 198b0051a5a2 to 33fccf564973 (1 revision) (flutter/flutter#109557)
…r (1/2) (flutter#6208)

Adds a size parameter to the BitmapDescriptor.fromBytes constructor, so web applications can specify the actual physical size of the bitmap.

The parameter is not needed (and ignored) in other platforms. Other platforms seem to be doing actual size / dpi to figure out the correct physical size.

Fixes (part 1) flutter/flutter#73789
…hared_preferences/shared_preferences_android/android (flutter#6264)
Currently, in some circumstances where a subclasses of
`PlatformInterface` erroneously uses `implements` rather than
`extends`, a `NoSuchMethodError` will be thrown (in spite of the
documentation at
https://pub.dev/documentation/plugin_platform_interface/latest/plugin_platform_interface/PlatformInterface/verify.html
claiming that `AssertionError` will be thrown).

After flutter/flutter#109339 is fixed, the
correct type of exception will be thrown.  To avoid tests breakages
when the fix happens, we need to modify these tests so that they don't
care what kind of exception is thrown.
@vikivyas
Copy link

vikivyas commented Feb 8, 2023

If all looks good, Please proceed to update.

@rekire
Copy link
Author

rekire commented Feb 8, 2023

To be honest I would not expect any merge soon

@vikivyas
Copy link

@rekire : If you I would not expect any merge soon, Can you update me how to use your code directly?

@rekire
Copy link
Author

rekire commented Feb 10, 2023

I'm using this in my project:

dependencies:
  # ...
  flutter_webview_pro:
    git:
      url: https://github.com/rekire/flutter-plugins-fork.git
      ref: 9713d3b589e8db565d2046bf8a11aee73af33aca #self_camera_check
      path: packages/webview_flutter/webview_flutter

dependency_overrides:
  webview_pro_android:
    git:
      url: https://github.com/rekire/flutter-plugins-fork.git
      ref: 9713d3b589e8db565d2046bf8a11aee73af33aca #self_camera_check
      path: packages/webview_flutter/webview_flutter_android

@rekire
Copy link
Author

rekire commented Feb 10, 2023

Well since this is technical "my" fork for the fork, we might discuss it in my fork instead of the fork of the fork of the fork :-D

So please open an issue here: https://github.com/rekire/flutter-plugins-fork/issues

@vikivyas
Copy link

Well since this is technical "my" fork for the fork, we might discuss it in my fork instead of the fork of the fork of the fork :-D

So please open an issue here: https://github.com/rekire/flutter-plugins-fork/issues

sure... why not...

@rekire
Copy link
Author

rekire commented Feb 10, 2023

I just noticed that issues were disabled in that repo I just enabled it for you

@vikivyas
Copy link

I just noticed that issues were disabled in that repo I just enabled it for you

Yes,It was! I am thank you for enabling issues. I have just create Webview Allow Camera Access is not working. flutter#132. See there after this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment