New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

giant/tiny numbers in unit test might fail #152

Closed

simon300000 opened this issue Dec 18, 2019 · 1 comment

Labels

numeral

Contributor

simon300000 commented Dec 18, 2019 •

edited

Loading

Currently using macOS 10.15.2 (19C57), Node.js 13.4.0

Basically the big numbers in unit test is hardcoded; but the numbers, the big ones...are little bit "strange" in JavaScript

2) hanzi2num
hanzi2num("無量大數")
should translate hanzi to number correctly:

AssertionError [ERR_ASSERTION]: 1e+68 == 1.0000000000000002e+68
+ expected - actual

-1e+68
+1.0000000000000002e+68

ref: #61 #38 #55

simon300000 changed the title ~~giant/tiny numbers in unit test might bring problem~~ giant/tiny numbers in unit test might fail

LingDong- added the numeral label

Member

antfu commented Feb 2, 2020

It should be fixed in recent testing updates. Thanks :)

antfu closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment