Conversation
index.html
Outdated
|
|
||
| <!-- Enable CodeMirror's search addons --> | ||
| <script src="node_modules/codemirror/addon/search/search.js" type="text/javascript"></script> | ||
| <script src="node_modules/codemirror/addon/search/jumpToLine.js" type="text/javascript"></script> |
There was a problem hiding this comment.
it looks like this should be jump-to-line.js, I'm getting an error otherwise
There was a problem hiding this comment.
That is strange. You are right about that import, but it worked for me initially and fixing it didn't seem to change anything. So I'm not sure what the deal with that is on my local machine.
|
Can we improve the UX a bit here? Searching from the command line doesn't work, for example. I don't think simply enabling CodeMirror's search is enough. |
|
I agree with you that the default code-mirror UX is pretty ugly, requiring Cmd+G to browse through results. So this PR doesn't finish the search feature, but it certainly moves it in the right direction while someone can work on improving the dialog boxes. |
|
Hey sorry this took so long for me to get to, I was away for a while. Could you rebase and then I will check it out/merge? |
2 participants
Included dialog addons for pretty search dialogs. #58