Encode cookies per RFC 3986

Author: zachborboa

src/Curl/Curl.php

@@ -204,7 +204,7 @@ public function setReferrer($referrer)
     public function setCookie($key, $value)
     {
         $this->cookies[$key] = $value;
-        $this->setOpt(CURLOPT_COOKIE, http_build_query($this->cookies, '', '; '));
+        $this->setOpt(CURLOPT_COOKIE, http_build_query($this->cookies, '', '; ', PHP_QUERY_RFC3986));
     }
 
     public function setCookieFile($cookie_file)

tests/PHPCurlClass/PHPCurlClassTest.php

@@ -331,6 +331,18 @@ public function testCookies()
         )) === 'yum');
     }
 
+    public function testCookieEncoding()
+    {
+        $curl = new Curl();
+        $curl->setCookie('cookie', 'Om nom nom nom');
+
+        $reflectionClass = new ReflectionClass('\Curl\Curl');
+        $reflectionProperty = $reflectionClass->getProperty('options');
+        $reflectionProperty->setAccessible(true);
+        $options = $reflectionProperty->getValue($curl);
+        $this->assertEquals('cookie=Om%20nom%20nom%20nom', $options[CURLOPT_COOKIE]);
+    }
+
     public function testCookieFile()
     {
         $cookie_file = dirname(__FILE__) . '/cookies.txt';