Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gracefully shutdown support for zookeeper #5

Closed
qdaxb opened this issue Apr 24, 2016 · 1 comment
Closed

gracefully shutdown support for zookeeper #5

qdaxb opened this issue Apr 24, 2016 · 1 comment
Labels
feature
Milestone
0.1.0

Comments

@qdaxb
Copy link
Collaborator

qdaxb commented Apr 24, 2016

We need a listener to start/stop zk client when heartbeat switcher is changed. Consul registry is implemented in a different way, it should be fixed too.
@qdaxb qdaxb added this to the 0.1.0 milestone Apr 24, 2016
@qdaxb
Copy link
Collaborator Author

qdaxb commented Apr 26, 2016

I refactored base classes of registry and switchers to support this feature. See #11

@qdaxb qdaxb mentioned this issue Apr 26, 2016
Merged
@qdaxb qdaxb closed this as completed Apr 28, 2016
@qdaxb qdaxb removed the enhancement label Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
1 participant
@qdaxb