Skip to content

emoji.lua: Add rofl=😂 and other improvements #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

emoji.lua: Add rofl=😂 and other improvements #586

wants to merge 1 commit into from
+362 −162

Conversation

@Nomarian
Copy link
Contributor

@Nomarian Nomarian commented Nov 3, 2025 •
edited
Loading

Script info

  • Script name:  emoji.lua
  • Version:  6
  • Requirements:  lua
  • Min WeeChat version: 
  • Script tags:  input

Description

Add rofl=😂, shut up linter/luacheck
Linter: functions explicitly go to _G or are local
Moved emoji table to the end and its divided by line (diffs were too big)
str2emoji(): simplify pattern
str2emoji(): gsub points to table instead of function (faster)
use string.find in conditionals not string.match
Use function alias for functions that all do the same thing
tabs search entire string :token: and look/replace with approximations

Checklist (script update)

  • Author has been contacted
  • Single commit, single file added
  • Commit message format: script_name.py X.Y: …
  • Script version and Changelog have been updated
  • For Python script: works with Python 3 (Python 2 support is optional)
  • Score 100 / 100 displayed by weechat-script-lint

@Nomarian
emoji.lua: Add rofl=😂 and other improvements
20a7a1a 
    Linter: functions explicitly go to _G or are local
    Emoji table is now downloaded from a db
    str2emoji(): simplify pattern, gsub points to table instead of function (faster)
    use string.find in conditionals not string.match
    Use function alias for functions that all do the same thing
    tabs search last :token: and look/replace with approximations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Nomarian