fix: turn app <button>s into <a>s
#112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows Shift / Ctrl + Clicking them to open in new tab and is overall more sensible with our `hashchange` approach. A side effect of this is that the app list items no longer change brightness on hover, which could be considered a positive side effect by some. Apparently the initial implementation of showing apps in a dialog did not have the `hashchange` handler yet, so that was probably the reason to use `<button>` instead of `<a>`: 58d8e44. The `hashchange` listener was added a few commits later: 7b294dc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Shift / Ctrl + Clicking them to open in new tab
and is overall more sensible with our
hashchangeapproach.A side effect of this is that the app list items
no longer change brightness on hover,
which could be considered a positive side effect by some.
Apparently the initial implementation of showing apps in a dialog
did not have the
hashchangehandler yet, so that was probablythe reason to use
<button>instead of<a>:58d8e44.
The
hashchangelistener was added a few commits later:7b294dc.
I have checked that clicking and opening the initial URL (like /website/apps/#wofwca-quake3) works.