Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Busy port detection #149

Closed
Neo2SHYAlien opened this issue Nov 14, 2020 · 2 comments · Fixed by #144
Closed

Busy port detection #149

Neo2SHYAlien opened this issue Nov 14, 2020 · 2 comments · Fixed by #144

Comments

@Neo2SHYAlien
Copy link
Contributor

What version of this package are you using?

webttorrent-cli --version  
3.0.7 (0.108.6)

What operating system, Node.js, and npm version?

Debian Sid
node --version                        
v12.19.0

What happened?

If I start and the port is used by some other application webtorrent-cli start twice the media player. For example if I use port 8000 (the default streaming port) with python3 -m http.server and try to start webtorrent-cli /link/path --vlc -t /subtitles/path -s 16 VLC is tarted twice. If I close one of the VLC players webttorrent closes immediately, no matters which VLC instance is closed. The very same behavior is observed with mpv/mplayer. I'm aware with port option in cli but still thinks this is a bug.

@Neo2SHYAlien Neo2SHYAlien changed the title Bussy port detection Busy port detection Nov 14, 2020
@feross feross added the bug label Nov 17, 2020
@feross
Copy link
Member

feross commented Nov 17, 2020

Agreed – this sounds like a bug. Anyone want to try fixing it in a PR?

@webtorrent-bot
Copy link

🎉 This issue has been resolved in version 3.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants