From b316d3afeb28e8f99f00a164b27f556d6f8485ea Mon Sep 17 00:00:00 2001
From: Ufuk Altinok <ufukaltinok@gmail.com>
Date: Wed, 28 Jan 2015 13:40:15 +0200
Subject: [PATCH] Handle empty url-list correctly (BEP19)

Commit amended by Feross Aboukhadijeh <feross@feross.org>
---
 index.js                                    |   6 ++++++
 test/empty-url-list.js                      |  11 +++++++++++
 test/torrents/leaves-empty-url-list.torrent | Bin 0 -> 1854 bytes
 3 files changed, 17 insertions(+)
 create mode 100644 test/empty-url-list.js
 create mode 100644 test/torrents/leaves-empty-url-list.torrent

diff --git a/index.js b/index.js
index f5e0387..48387c1 100644
--- a/index.js
+++ b/index.js
@@ -64,6 +64,12 @@ function decodeTorrentFile (torrent) {
   result.announce = [].concat.apply([], result.announceList)
 
   // handle url-list (BEP19 / web seeding)
+  if (Buffer.isBuffer(torrent['url-list'])) {
+    // some clients set url-list to empty string
+    torrent['url-list'] = torrent['url-list'].length > 0
+      ? [ torrent['url-list'] ]
+      : []
+  }
   result.urlList = (torrent['url-list'] || []).map(function (url) {
     return url.toString()
   })
diff --git a/test/empty-url-list.js b/test/empty-url-list.js
new file mode 100644
index 0000000..a8bea33
--- /dev/null
+++ b/test/empty-url-list.js
@@ -0,0 +1,11 @@
+var fs = require('fs')
+var parseTorrent = require('../')
+var test = require('tape')
+
+var leavesUrlList = fs.readFileSync(__dirname + '/torrents/leaves-empty-url-list.torrent')
+
+test('parse empty url-list', function (t) {
+  var torrent = parseTorrent(leavesUrlList)
+  t.deepEqual(torrent.urlList, [])
+  t.end()
+})
diff --git a/test/torrents/leaves-empty-url-list.torrent b/test/torrents/leaves-empty-url-list.torrent
new file mode 100644
index 0000000000000000000000000000000000000000..d6c2d8b2a6521f2d00eb57bfb8c6baeef551d635
GIT binary patch
literal 1854
zcma)-X*kr20>(olWZx!Bg=}HQ%$S+R*fZvKQW-)yCC2y<a~d;a7R0f;ha9_XM`f)T
zWNDB~)@u~mm+VU@+^ne(xt@EUb3fes<$isi_xJq1y{{(*OQg~092yBQ!eBX`46LCc
zn@J?y1(;9<$Ad~Cd9a}*x(^luGyJm%H~J3)p;B0ED)s+H0V)#tUluw8pm|W(Y&w$(
z(Ei5-07o_w6CkoFbeftckquDbNEjLoH$ov%a3mbSU;!G5?n$9}p|DPlcnAiGrO?Q9
zPc)Va(7f2*6gUEX)H4Q<SQ^m>Kp>8Cq94G5(8&-lCXvNL2N**co@6)z%b)-xK<!Tq
zZG=Gr=zoVSI0^~Fs*J<^e>&T|6S*cVmcFDMA_FhRzjEgx&s<gy38@;~^%~Zz^GK~4
z0h4DtUD(}F`ig7ADxPML<&{qpledC}MQDH9*|eC?-I(|iA#=5nl`IgO7*N%|Q~A5*
z=u9M0CJcwOC9KcVxYUIwTl@GlCd@{~xPu(wl3Y(9o>wG$J>fJe+Mu|Tr`5L^phbhI
zkc^ZF&%wXT{v3(j`M^6ZrC|=aR1|b<wnJbB6S#aQG^vUz{;9NW7NqE<1q~f|#}h3y
zxCvD`9++w7DAW*|m*o_xbge&;W|9E09I>g<oeMjNQeLl-jdvR}94NeZSB$(39bl$m
z_C#;!$X|-s22WzEI@Ux}xIsIR4CS(xTa?Icfsx~s(+BgfxF@uv98N5I$F#2UWt-X1
z(YQVT6|u!aA9?AdmmdeFR4y8kPVRO}n^zfg=4*t{)|(zv%!2v%f8tlF{zZGgfQErq
z#Oq_nF@4vNv9Ea`Y4js?f7=qifb{hNj|9<P)<M9Ewsd=2Ww*PIh0;m5^3q3rL5<Hd
zX<co0?#)B3XF^<e^o;%Hq%UozGfIbWv({Uye)?T>g#-T9UX=B+&Qy4v`HkqROjmV3
z?K%YdWlk*ocwwc^SZ2G>n92&F=C|xF&^)i!8n!Rs{)@ZcSJ}&mQe1DkIo4iXdEsR}
z0iiecB2z1-yl<8?LA5wL!jOz9EOvXA*Wk>Ju@de^dqj^8eJ7O|1aA<<9h>fnXPl`^
zW&EaJ{;W53@@CG^@KuVMMSxT}JBeYvGJa-5hXUWrU1{P*2MkX9yy2+x=Bf_LzjIU1
z8k0D1rFud$Hh!2p9tKt|tRu|SJ*vsoup5ax)a4<NYl{39B<2D7iBd9Eij_@Z)on)*
zg78_np*=rTYnkhI89IUb>HJ^??9|kIp`?!L8GXC<db#l1uf(0aK^o7s-H{T_&15;d
zWuxJKKGkv>RQu~RWLjb<`}X=by!s~sPujL}!NH~@sZ^e!?d2LFclg=IvEReYrDW-Z
z>)x8U-s7o`Q`u{1o39^BOd%4%2Q6`7B%v>P1tWvY{?76WWtP(_VkvbVS`hn}`tZG)
z0A8=|j|ES2R#tKxwD}w|OTH`$Bv;+_dj7}5xp=E`%%pps{@c8BYd69#ueM~Rs(@g%
zI|e!8q7v3uRgM+q)zZlqL-VBZ9Qv>4^Kn~2HvcGTxL&bvi1;C+s8!?dggAUm&rOmE
z8;GI<)B63I^sm(t1^rJsrrc?9u;oHfsCQ?WXS{m3)4|gsL0)^5-Q;fMO!20O!<(@=
z+n=s;-RP|bx57L6KUMqO$17QAry=hAaiBeX@P0h;8DH|m{6q-s8iGMEQchj$@w&SL
zDP0m7dY$rp0QOm0SX;{sTAyiL<Xf|5(Rd-aZ>7!Y>Ha;Yy2&43*KD7>h`G4lI0;&r
zK#>kEoNC0x4n=PW=hxpd6w4!>@5#rchWg}#!4eXU)~@-%k0Sud)Z%LU8hmh1_wv?a
zA@26OPFzrD^R`GJ;i=nF^mu`QVkWz+{NZiAzb#++;;_d__Y^p}t083Hq@F1Fedqug
zqqWa>ta94SesA||(^;4MCXCc7=#GkvTh1skaZLS2e~wQ_Nm5od4=ch&&?tcirh#BH
zSj*AI^J@nVd(?5zbV6HSYl2n7TTNYG-y62#mUkL6lV5|Lo3A&`@rz$=l+22RxqPse
zGf`_xbgO_Oh83wK+_)e`?%d!v8-<VTnJ$OUyP{?}k3`?jniXyAZh<)$N#4ah5mE&u
zbyFiPT1|bB7K2z&^nKLt7dm~BK@+A0>xbZL7{N+krFXnx39)jwI6JHCirIAc#Yd-2
zoymD}Zii)3s*-B^ju%vu5_+db5Tk^|D=Ldv&dr{EXOloEZ?vj6VW(IvFUJg0;=%XL
z-YA>1P%u&C*w3CCd?5=y4mlOHB~@GW!C->bM4+Dc3mEfuNfb(ZT>nmN?qQJM98o8Q
zK*5_iYd*(8SIMic;e)N|K@XaKDIRciBB)u(NZgmLJr?}ep-bJkqrc%WssFk?7#8>^
Dq^V_2

literal 0
HcmV?d00001