Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace meta.children with meta.template #1676

Merged
merged 1 commit into from
May 25, 2023
Merged

Replace meta.children with meta.template #1676

merged 1 commit into from
May 25, 2023

Conversation

TrySound
Copy link
Member

Ref #1569

Here we change template in meta to include current component instead of implicitly creating it.

This way we can provide insert composition of components instead of single one for example input+label. Or even wrap current component like label>input.

Another usecase is ability to set local styles and props for current component.

Note: review with hidden whitespaces

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • test it on preview
  • hi @rpominov, I need you to do
    • detailed review (read every line)

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@TrySound
Replace meta.children with meta.template
ab83846 
Ref #1569

Here we change template in meta to include current component instead of
implicitly creating it.

This way we can provide insert composition of components instead of
single one for example input+label. Or even wrap current component like
label>input.

Another usecase is ability to set local styles and props for current
component.
@TrySound TrySound requested review from kof and rpominov May 25, 2023 16:23
@vercel
Copy link

vercel bot commented May 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview May 25, 2023 4:25pm

kof
kof approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great

kof

This comment was marked as duplicate.

Sign in to view

kof

This comment was marked as duplicate.

Sign in to view

@TrySound TrySound merged commit 40e97a1 into main May 25, 2023
@TrySound TrySound deleted the meta-template branch May 25, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kof kof kof approved these changes

@rpominov rpominov Awaiting requested review from rpominov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrySound @kof