Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: websockets/ws
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8.6.0
Choose a base ref
...
head repository: websockets/ws
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8.8.1
Choose a head ref
  • 20 commits
  • 10 files changed
  • 3 contributors

Commits on May 20, 2022

  1. [minor] Clarify why the handshake is aborted

    Add more details about why the handshake is aborted in the HTTP
    response.
    
    Refs: #2045 (comment)
    lpinca committed May 20, 2022
    Configuration menu
    Copy the full SHA
    e56cdfe View commit details
    Browse the repository at this point in the history

Commits on May 21, 2022

  1. [fix] Abort the handshake if the Upgrade header is invalid

    Close the connection if the Upgrade header field in the HTTP response
    contains a value that is not an ASCII case-insensitive match for the
    value "websocket".
    lpinca committed May 21, 2022
    Configuration menu
    Copy the full SHA
    0fdcc0a View commit details
    Browse the repository at this point in the history
  2. [minor] Use consistent error messages

    Make some server error messages consistent with the respective client
    error messages.
    lpinca committed May 21, 2022
    Configuration menu
    Copy the full SHA
    fb658bd View commit details
    Browse the repository at this point in the history
  3. [test] Increase code coverage

    lpinca committed May 21, 2022
    Configuration menu
    Copy the full SHA
    8889e48 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a690791 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. [security] Drop sensitive headers when following insecure redirects

    Drop the `Authorization` and `Cookie` headers if the original request
    for the opening handshake is sent over HTTPS and the client is
    redirected to the same host over plain HTTP (wss: to ws:).
    
    If an HTTPS server redirects to same host over plain HTTP, the problem
    is on the server, but handling this condition is not hard and reduces
    the risk of leaking credentials due to MITM issues.
    
    Refs: 6946f5fe
    lpinca committed May 26, 2022
    Configuration menu
    Copy the full SHA
    d68ba9e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    903ec62 View commit details
    Browse the repository at this point in the history
  3. [feature] Introduce the 'wsClientError' event (#2046)

    Add the ability to inspect the invalid handshake requests and respond
    to them with a custom HTTP response.
    
    Closes #2045
    lpinca committed May 26, 2022
    Configuration menu
    Copy the full SHA
    6e5a5ce View commit details
    Browse the repository at this point in the history
  4. [dist] 8.7.0

    lpinca committed May 26, 2022
    Configuration menu
    Copy the full SHA
    4b62fbf View commit details
    Browse the repository at this point in the history

Commits on May 30, 2022

  1. [test] Fix typo

    lpinca committed May 30, 2022
    Configuration menu
    Copy the full SHA
    5e4149e View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2022

  1. Configuration menu
    Copy the full SHA
    a6dbd1c View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Configuration menu
    Copy the full SHA
    c1a126f View commit details
    Browse the repository at this point in the history
  2. [doc] Fix nit

    lpinca committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    0792742 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. [feature] Add the WS_NO_{BUFFER_UTIL, UTF_8_VALIDATE} variables

    When set to non empty values, the `WS_NO_BUFFER_UTIL` and
    `WS_NO_UTF_8_VALIDATE` environment variables, prevent the optional
    `bufferutil` and `utf-8-validate` dependencies  from being required,
    respectively.
    
    These might be useful to enhance security in systems where a user can
    put a package in the package search path of an application of another
    user, due to how the Node.js resolver algorithm works.
    lpinca authored Jun 9, 2022
    Configuration menu
    Copy the full SHA
    becf237 View commit details
    Browse the repository at this point in the history
  2. [dist] 8.8.0

    lpinca committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    982b782 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2022

  1. [minor] Prevent opening handshake headers from being overridden

    Ensure that the `Connection`, `Sec-WebSocket-Key`,
    `Sec-WebSocket-Version`, and `Upgrade` headers are not overridden.
    
    Refs: #2048 (comment)
    lpinca committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    3b6af82 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. [doc] Fix typo (#2062)

    leetrout authored Jun 30, 2022
    Configuration menu
    Copy the full SHA
    1117af6 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2022

  1. [test] Fix nits

    lpinca committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    0ae302a View commit details
    Browse the repository at this point in the history
  2. [security] Fix same host check for ws+unix: redirects

    Drop the `Authorization` and `Cookie` headers if the original request
    for the opening handshake is sent to an IPC server and the client is
    redirected to a TCP server (ws+unix: to ws: or wss:), and vice versa
    (ws: or wss: to ws+unix).
    
    Also drop the `Authorization` and `Cookie` headers if the original
    request for the opening handshake is sent to an IPC server and the
    client is redirected to another IPC server.
    
    Refs: 6946f5fe
    lpinca committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    bc8bd34 View commit details
    Browse the repository at this point in the history
  3. [dist] 8.8.1

    lpinca committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    9753821 View commit details
    Browse the repository at this point in the history
Loading