Update to support Hyper 0.11?

[generalelectrix]

Hyper broke a lot of stuff moving to 0.11, and all of the contemporary Hyper examples are incompatible with rust-websocket. Any horizon on a patch to support the latest Hyper?

[illegalprime]

Party! That means they're finally async! That should remove a lot of weird glue I used to hold the two together lol. This is planned, are you hoping to just have it use 0.11 or are you looking for something in particular?

[generalelectrix]

Just looking for the 0.11 update. And yes, all of the examples are fundamentally async and are definitely a lot cleaner looking than they were pre-0.11.

[generalelectrix]

Do you happen to have a vague sense of when this might happen? It would be helpful to me in my project planning, as I can defer development of my websocket-related piece if it means not having to refactor later to get up to the newest hyper. If its more like a months-from-now kind of thing then I will go ahead and implement using the current version and hyper 0.10 and perhaps refactor later. Thank you!

[illegalprime]

I'll try to see what I can do this week and I'll let you know, I feel like it's going to be a small change but I'm always wrong about these things 🙂

[illegalprime]

@generalelectrix I already ran into issues ^

[chrismacklin]

Ok, thanks for the update! I'll move ahead running on hyper 0.10 for the time being. Thank you for your work on this library, it is working nicely and is easy to use.

[dthul]

Yes, that would be awesome! I started a new project like two hours ago and already got stuck on this issue. My setup: Hyper (0.11) listens on Port 80 for incoming connections. If the hyper request matches a certain path (like "/websocket") I try to upgrade the connection. At the moment this fails with:

error[E0308]: mismatched types
  --> src/main.rs:60:36
   |
60 |                 match HyperRequest(req).into_ws() {
   |                                    ^^^ expected struct `hyper::server::request::Request`, found struct `hyper::Request`
   |
   = note: expected type `hyper::server::request::Request<'_, '_>`
              found type `hyper::Request`

Since the request types of the two hyper versions don't match.

[illegalprime]

@dthul Yeah it's expecting the hyper 0.10 version of that request. For now you can upgrade it manually by implementing IntoWs for a hyper request.

[illegalprime]

I think the move is to ditch hyper in favor of making it an optional feature that allows integrating it into the lib. That will be pretty tough though, but it'll make the crate leaner.

[dthul]

@illegalprime Thanks for the tip with IntoWs. I didn't put too much time into it but it looks like it is not totally straightforward to implement this for a hyper 0.11 request. IntoWs requires a stream that implements AsyncRead and AsyncWrite but Hyper gives you a futures::future::Stream which implements neither of those.

[illegalprime]

@dthul I'll take a look when I get home, it gets down to how do you extract the stream that hyper is giving us.

[illegalprime]

@dthul I still need to test this, but I think what you have to do is verify the headers yourself, create a TcpConnection connecting to https://docs.rs/hyper/0.11.0/hyper/struct.Request.html#method.remote_addr , send the rest of the handshake, and finally wrap the connection in the websocket codec. This is too involved for a normal user so I want to push a hotfix soon that will implement IntoWs for an (AsyncTcpStream, Headers). This hyper version changes a lot, so I want to get rid of the hyper dependency soon.

[dthul]

I get a "connection refused" error when I try to connect to the remote_addr that I get from the Hyper request. Does TCP even allow you to connect to an existing client socket?

[illegalprime]

@dthul oh I see. Yeah this is really tough, unless we can get access to the live connection hyper is using we can't transform it into websockets. If there's no way to do it I'll open a bug in hyper.