the video buffers need disposable flags so the the GC doesn't clean up too late from C# layer

robin-raymond · robin-raymond · commit 36fbed918597 · 2019-04-02T16:29:38.000-04:00
diff --git a/idl/VideoBuffers.idl b/idl/VideoBuffers.idl
@@ -107,6 +107,7 @@ namespace org
       VideoFrameNativeBuffer nativeFrame;
     };
 
+    [disposable]
     interface VideoFramePlanarYuvBuffer : VideoFrameBuffer
     {
       [constructor, default, delete]
@@ -155,6 +156,7 @@ namespace org
       VideoData v;
     };
 
+    [disposable]
     interface VideoFramePlanarYuvaBuffer : VideoFramePlanarYuvBuffer
     {
       [constructor, default, delete]
@@ -171,6 +173,7 @@ namespace org
       VideoData a;
     };
 
+    [disposable]
     interface VideoFrameNativeBuffer : VideoFrameBuffer
     {
       [constructor, default, delete]

Original file line number	Diff line number	Diff line change
`@@ -107,6 +107,7 @@ namespace org`
`107`	`107`	`VideoFrameNativeBuffer nativeFrame;`
`108`	`108`	`};`
`109`	`109`
	`110`	`+ [disposable]`
`110`	`111`	`interface VideoFramePlanarYuvBuffer : VideoFrameBuffer`
`111`	`112`	`{`
`112`	`113`	`[constructor, default, delete]`
`@@ -155,6 +156,7 @@ namespace org`
`155`	`156`	`VideoData v;`
`156`	`157`	`};`
`157`	`158`
	`159`	`+ [disposable]`
`158`	`160`	`interface VideoFramePlanarYuvaBuffer : VideoFramePlanarYuvBuffer`
`159`	`161`	`{`
`160`	`162`	`[constructor, default, delete]`
`@@ -171,6 +173,7 @@ namespace org`
`171`	`173`	`VideoData a;`
`172`	`174`	`};`
`173`	`175`
	`176`	`+ [disposable]`
`174`	`177`	`interface VideoFrameNativeBuffer : VideoFrameBuffer`
`175`	`178`	`{`
`176`	`179`	`[constructor, default, delete]`