Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pytest directly. setup.py test was removed in setuptools 72. #172

Conversation

white-gecko
Copy link
Contributor

Run pytest directly. setup.py test was removed in setuptools 72.
https://setuptools.pypa.io/en/latest/history.html#v72-0-0

Derived from #169 . Lets split it into portions.

@wumpus
Copy link
Collaborator

wumpus commented Aug 20, 2024

Hm. Code coverage is not currently working, which makes it difficult to properly test this PR.

@white-gecko
Copy link
Contributor Author

There is coverage output in the logs:

https://github.com/webrecorder/warcio/actions/runs/10406578911/job/28991147343?pr=172#step:7:337

---------- coverage: platform linux, python 3.11.9-final-0 -----------
Name                              Stmts   Miss Branch BrPart  Cover
-------------------------------------------------------------------
warcio/__init__.py                    3      0      0      0   100%
warcio/archiveiterator.py           133      0     36      0   100%
warcio/bufferedreaders.py           202      2     72      1    99%
warcio/capture_http.py              159      1     48      2    99%
warcio/checker.py                    53      0     22      0   100%
warcio/cli.py                        50      0      0      0   100%
warcio/digestverifyingreader.py     106      0     46      0   100%
warcio/exceptions.py                  4      0      0      0   100%
warcio/extractor.py                  29      0     12      0   100%
warcio/indexer.py                    62      2     30      1    97%
warcio/limitreader.py                40      0     14      1    98%
warcio/recompressor.py               57      0     14      0   100%
warcio/recordbuilder.py             147      0     72      7    97%
warcio/recordloader.py              208      0     86      3    99%
warcio/statusandheaders.py          188      1     68      3    98%
warcio/timeutils.py                  75      0     12      0   100%
warcio/utils.py                      45      0     16      0   100%
warcio/warcwriter.py                 91      0     28      2    98%
-------------------------------------------------------------------
TOTAL                              1652      6    576     20    99%

@white-gecko
Copy link
Contributor Author

On master it is currently:

https://github.com/webrecorder/warcio/actions/runs/10468183347/job/28988504338#step:6:364

---------- coverage: platform linux, python 3.11.9-final-0 -----------
Name                              Stmts   Miss Branch BrPart  Cover
-------------------------------------------------------------------
warcio/__init__.py                    3      0      0      0   100%
warcio/archiveiterator.py           133      0     36      0   100%
warcio/bufferedreaders.py           202      2     72      1    99%
warcio/capture_http.py              159      1     48      2    99%
warcio/checker.py                    53      0     22      0   100%
warcio/cli.py                        55      4      0      0    93%
warcio/digestverifyingreader.py     106      0     46      0   100%
warcio/exceptions.py                  4      0      0      0   100%
warcio/extractor.py                  29      0     12      0   100%
warcio/indexer.py                    62      2     30      1    97%
warcio/limitreader.py                40      0     14      1    98%
warcio/recompressor.py               57      0     14      0   100%
warcio/recordbuilder.py             147      0     72      7    97%
warcio/recordloader.py              208      0     86      3    99%
warcio/statusandheaders.py          188      1     68      3    98%
warcio/timeutils.py                  75      0     12      0   100%
warcio/utils.py                      45      0     16      0   100%
warcio/warcwriter.py                 91      0     28      2    98%
-------------------------------------------------------------------
TOTAL                              1657     10    576     20    99%

@white-gecko
Copy link
Contributor Author

The only difference is:

Name                              Stmts   Miss Branch BrPart  Cover
-------------------------------------------------------------------
warcio/cli.py                        55      4      0      0    93% (on master)
warcio/cli.py                        50      0      0      0   100% (on this pr)

While I don't get the value for faster, since the new test for version was introduced in 29da916.

The coverage stays the same resp. has increased for warcio/cli.py.

@wumpus
Copy link
Collaborator

wumpus commented Aug 21, 2024

Thank you, perfect, I should have looked more carefully at the logs.

@wumpus wumpus merged commit 12eca85 into webrecorder:master Aug 21, 2024
5 checks passed
@white-gecko white-gecko deleted the feature/runPytestDirectly branch August 21, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants