Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3.12 and setuptools #181

Open
wumpus opened this issue Aug 31, 2024 · 6 comments
Open

py3.12 and setuptools #181

wumpus opened this issue Aug 31, 2024 · 6 comments
Assignees

Comments

@wumpus
Copy link
Collaborator

wumpus commented Aug 31, 2024

In all of that flurry of CI work: while the CI explicitly installs setuptools for >=py3.12, ... after we release a new pypi version, are py3.12-using end-users going to have to explicitly install setuptools before doing pip install pypi?

Cc @white-gecko

@wumpus wumpus self-assigned this Aug 31, 2024
@Florents-Tselai
Copy link

while the CI explicitly installs setuptools for >=py3.12

I noticed that but couldn't understand why it has to. e.g. here's a pretty standard yml file and haven't had to touch setuptools explicitly.

py3.12-using end-users going to have to explicitly install setuptools before doing

Probably not, the virtualenv creator should have taken care of that already.

Also just tried python3.12 -m pip install warcio and worked fine.

@white-gecko
Copy link
Contributor

I think https://docs.python.org/dev/whatsnew/3.12.html#ensurepip is, what you are looking for.

Since python 3.12, venv, virtualenvwrapper does not install setuptools on its own. If I don't overlook anything, since 29da916 setuptools is no longer required to run warcio. pip install warcio works without setuptools, but to install warcio via its setup.py, setuptools obviously is required and needs to be installed if it is not present.

@nvanderperren
Copy link

nvanderperren commented Oct 8, 2024

I had to install setuptools (pip install setuptools) in my virtualenv with python 3.12 in order to run warcio check.

I had a ModuleNotFoundError: No module named 'pkg_resources' after installing it with pip install warcio without having setuptools.

@white-gecko
Copy link
Contributor

@nvanderperren are you on the current master or which version are you running?

@nvanderperren
Copy link

I just did pip install warcio as mentioned in the README. That is warcio 1.7.4

@white-gecko
Copy link
Contributor

Yes, this one would still require setuptools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants