-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Fix related link format #5312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix related link format #5312
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/AjPWG99LyU5yaqHjxuxByN5L8DsD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
@chenxsan I was going to dive deeper into this linting error, but thanks for jumping in and tweaking it! My hesitancy was due to two things:
I think there's going to be a better tweak (perhaps at linter configuration level) to this collaborative quick patch we shipped :) I might take a stab at it later, just to sate my curiosity... |
@atesgoral Regarding your second concern, here's an explanation for why we would migrate to MDX #4412 (comment) considering this site is actually an application built with React :) Generally, MDX improves the performance a lot because we can take advantage of MDX's MDXProvider. And yes, it seems to be a bug in eslint-mdx. Let me know if you come to any conclusion. Or I can file an issue over their repository, the maintainer is very kind to help as far as I know. |
@chenxsan I couldn't figure out how to tweak the ESLint configuration to make the problem go away. |
@astonizer I've filed an issue over the eslint-mdx repository, we'll see if it's a bug in it. |
The Further Reading section on https://webpack.js.org/guides/code-splitting/ has a dangling
>
:Fixing this by converting the HTML entities to the actual angle brackets:
Note: The last item in this list completely omits the
<link>
and just mentionsrel="preload"
, so it could also be a good idea to standardize either using a<link>
or not.