fix(run-open): introduce open instead of opn #2532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v4 #2532 +/- ##
=======================================
Coverage 93.77% 93.77%
=======================================
Files 34 34
Lines 1334 1334
Branches 381 381
=======================================
Hits 1251 1251
Misses 81 81
Partials 2 2
Continue to review full report at Codecov.
|
|
@hiroppy Let's send the first PR with updating package.json/babel + drop old nodejs on CI for |
|
Anyway good job! |
hiroppy
force-pushed
the
feature/add-open
branch
from
21c1f14 to
ca7346f
Compare
|
@evilebottnawi I'm working on the updating deps on another pr. please review this |
|
/cc @Loonride |
knagaitsev
approved these changes
Apr 27, 2020
|
Thanks! |
alexander-akait
pushed a commit
that referenced
this pull request
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
modified
Motivation / Use-Case
opn is deprecated.
Breaking Changes
yes because open doesn't support Node6.
Additional Info