-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(package): migrate to schema-utils
(dependencies
)
#1464
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1464 +/- ##
=========================================
+ Coverage 78.94% 83.5% +4.56%
=========================================
Files 5 4 -1
Lines 494 382 -112
Branches 161 113 -48
=========================================
- Hits 390 319 -71
+ Misses 104 63 -41
Continue to review full report at Codecov.
|
lib/options.json
Outdated
"type": "string" | ||
}, | ||
"https": { | ||
"description": "Enable HTTPS for server.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't remove description, In the future, we can derive more friendly errors based on them
42f01c7
to
2a5efa1
Compare
Codecov Report
@@ Coverage Diff @@
## master #1464 +/- ##
========================================
Coverage ? 73.3%
========================================
Files ? 10
Lines ? 663
Branches ? 0
========================================
Hits ? 486
Misses ? 177
Partials ? 0
Continue to review full report at Codecov.
|
2a5efa1
to
daa2180
Compare
schema-utils
(dependencies
)schema-utils
(dependencies
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I'm just worried if we did not forget anything, maybe we'll add more tests
I can add some more, but tried to use at least one for ever different pattern for now. 'Some more' won't likely make it more reliable if we're not testing all of them then 😯 |
|
daa2180
to
8010160
Compare
Type
Issues
SemVer