-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
refactoring and replacing bin/webpack-dev-server #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## beta #1102 +/- ##
=======================================
Coverage 71.92% 71.92%
=======================================
Files 5 5
Lines 463 463
Branches 148 148
=======================================
Hits 333 333
Misses 130 130 Continue to review full report at Codecov.
|
Maybe this could align well with the CLI efforts to merge into webpack? |
@ev1stensberg my apologies, I'm not following. I'm not aware of an effort to merge this project with the main webpack project. |
please weigh in if you have comments on this refactor |
I'll take a look at it tomorrow, may be no conflicts at all |
@ev1stensberg will likely merge and move forward tomorrow morning ET. not to say I can't make modifications should discussion warrant, but I let this sit for a week for comment and gotta get moving on the other aspects of the v4 milestone 😄 |
Sure, I think the only issue here would be that you'd ( in the future ) access an empty repo, and you'd need to change the imports to the cli instead of regular webpack, if you understand |
* refactoring and replacing bin/webpack-dev-server * cleaning up param passing * fixing func signatures
What kind of change does this PR introduce?
Replaces
bin/webpack-dev-server
withcli.js
and abin
entry inpackage.json
Removes
bin/webpace-dev-server
Refactors the entire CLI codebase.
Did you add or update the
examples/
?Not as yet. This will be done once the refactor is approved.
Summary
The intention behind the refactor is to provide a more modular CLI codebase that can be tested along with the API to improve coverage and consistency between releases. This refactor will also lend to the future effort of synch'ing the CLI and API.
This PR also aims to improve the readability and maintainability of the code.
Does this PR introduce a breaking change?
The goal is not to :)
Other information
Once the refactor is approved the following will be added to this PR; tests will be created around the various modules for the CLI, the CLI will be tested against all examples, and the example READMEs will be updated to reflect the new CLI path.
PR will remain open for comments until Monday Sept 25th. Note that this will be merged into the
beta
branch, and notmaster
until v3 is complete.