Skip to content

refactoring and replacing bin/webpack-dev-server #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2017
Merged

refactoring and replacing bin/webpack-dev-server #1102

merged 4 commits into from
Sep 26, 2017

Conversation

shellscape
Copy link
Contributor

@shellscape shellscape commented Sep 18, 2017

What kind of change does this PR introduce?
Replaces bin/webpack-dev-server with cli.js and a bin entry in package.json
Removes bin/webpace-dev-server
Refactors the entire CLI codebase.

Did you add or update the examples/?
Not as yet. This will be done once the refactor is approved.

Summary
The intention behind the refactor is to provide a more modular CLI codebase that can be tested along with the API to improve coverage and consistency between releases. This refactor will also lend to the future effort of synch'ing the CLI and API.

This PR also aims to improve the readability and maintainability of the code.

Does this PR introduce a breaking change?
The goal is not to :)

Other information
Once the refactor is approved the following will be added to this PR; tests will be created around the various modules for the CLI, the CLI will be tested against all examples, and the example READMEs will be updated to reflect the new CLI path.

PR will remain open for comments until Monday Sept 25th. Note that this will be merged into the beta branch, and not master until v3 is complete.

@shellscape shellscape added this to the Version 3 milestone Sep 18, 2017
@codecov
Copy link

codecov bot commented Sep 18, 2017

Codecov Report

Merging #1102 into beta will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             beta    #1102   +/-   ##
=======================================
  Coverage   71.92%   71.92%           
=======================================
  Files           5        5           
  Lines         463      463           
  Branches      148      148           
=======================================
  Hits          333      333           
  Misses        130      130

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e24ac4...c3e9320. Read the comment docs.

@shellscape shellscape changed the base branch from master to beta September 18, 2017 18:53
@shellscape shellscape mentioned this pull request Sep 18, 2017
19 tasks
@evenstensberg
Copy link
Member

Maybe this could align well with the CLI efforts to merge into webpack?

@shellscape
Copy link
Contributor Author

@ev1stensberg my apologies, I'm not following. I'm not aware of an effort to merge this project with the main webpack project.

@shellscape
Copy link
Contributor Author

please weigh in if you have comments on this refactor

@evenstensberg
Copy link
Member

I'll take a look at it tomorrow, may be no conflicts at all

@shellscape
Copy link
Contributor Author

@ev1stensberg will likely merge and move forward tomorrow morning ET. not to say I can't make modifications should discussion warrant, but I let this sit for a week for comment and gotta get moving on the other aspects of the v4 milestone 😄

@evenstensberg
Copy link
Member

Sure, I think the only issue here would be that you'd ( in the future ) access an empty repo, and you'd need to change the imports to the cli instead of regular webpack, if you understand

@shellscape shellscape merged commit 3e24443 into beta Sep 26, 2017
shellscape added a commit that referenced this pull request Sep 27, 2017
* refactoring and replacing bin/webpack-dev-server

* cleaning up param passing

* fixing func signatures
@shellscape shellscape deleted the v3 branch November 27, 2017 14:39
@michael-ciniawsky michael-ciniawsky removed this from the 3.1.6 milestone Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants