chore(options): move public path handling to api side

Author: knagaitsev

lib/utils/createConfig.js

@@ -47,21 +47,6 @@ function createConfig(config, argv, { port }) {
     options.overlay = argv.overlay;
   }
 
-  options.devMiddleware = options.devMiddleware || {};
-
-  if (!options.devMiddleware.publicPath) {
-    // eslint-disable-next-line
-    options.devMiddleware.publicPath =
-      (firstWpOpt.output && firstWpOpt.output.publicPath) || '';
-
-    if (
-      !isAbsoluteUrl(String(options.devMiddleware.publicPath)) &&
-      options.devMiddleware.publicPath[0] !== '/'
-    ) {
-      options.devMiddleware.publicPath = `/${options.devMiddleware.publicPath}`;
-    }
-  }
-
   if (!options.watchOptions && firstWpOpt.watchOptions) {
     options.watchOptions = firstWpOpt.watchOptions;
   }

lib/utils/normalizeOptions.js

@@ -1,6 +1,12 @@
 'use strict';
 
+const isAbsoluteUrl = require('is-absolute-url');
+
 function normalizeOptions(compiler, options) {
+  const firstWpOpt = compiler.compilers
+    ? compiler.compilers[0].options
+    : compiler.options;
+
   // Setup default value
   options.serveIndex =
     typeof options.serveIndex !== 'undefined' ? options.serveIndex : true;
@@ -51,6 +57,20 @@ function normalizeOptions(compiler, options) {
   }`;
 
   options.devMiddleware = options.devMiddleware || {};
+
+  // this was previously done in createConfig, but it should be done
+  // here for CLI/API uniformity
+  if (!options.devMiddleware.publicPath) {
+    options.devMiddleware.publicPath =
+      (firstWpOpt.output && firstWpOpt.output.publicPath) || '';
+
+    if (
+      !isAbsoluteUrl(String(options.devMiddleware.publicPath)) &&
+      options.devMiddleware.publicPath[0] !== '/'
+    ) {
+      options.devMiddleware.publicPath = `/${options.devMiddleware.publicPath}`;
+    }
+  }
 }
 
 module.exports = normalizeOptions;