test: update

Author: hiroppy

lib/Server.js

@@ -737,7 +737,7 @@ class Server {
         this.sockWrite([connection], 'log-level', this.clientLogLevel);
       }
 
-      if (this.options.hot) {
+      if (this.options.hot === true || this.options.hot === 'only') {
         this.sockWrite([connection], 'hot');
       }
 

lib/utils/updateCompiler.js

@@ -57,7 +57,7 @@ function updateCompiler(compiler, options) {
     });
 
     // do not apply the plugin unless it didn't exist before.
-    if (options.hot || options.hot === 'only') {
+    if (options.hot === true || options.hot === 'only') {
       compilersWithoutHMR.forEach((compiler) => {
         // addDevServerEntrypoints above should have added the plugin
         // to the compiler options

test/e2e/TransportMode.test.js

@@ -8,25 +8,27 @@ const {
   initConsoleDelay,
   awaitServerCloseDelay,
 } = require('../helpers/puppeteer-constants');
-const isWebpack5 = require('../helpers/isWebpack5');
 
 describe('transportMode client', () => {
   const modes = [
     {
       title: 'sockjs',
       options: {
+        hot: false,
         transportMode: 'sockjs',
       },
     },
     {
       title: 'ws',
       options: {
+        hot: false,
         transportMode: 'ws',
       },
     },
     {
       title: 'custom client',
       options: {
+        hot: false,
         transportMode: {
           server: 'sockjs',
           client: require.resolve(
@@ -78,16 +80,7 @@ describe('transportMode client', () => {
                         res.splice(i, 1);
                       }
                     }
-
-                    // TODO: delete this code when getting rid of webpack5
-                    if (isWebpack5) {
-                      const swap = res[0];
-                      res[0] = res[1];
-                      res[1] = swap;
-                    }
-
                     expect(res).toMatchSnapshot();
-
                     done();
                   });
                 });

test/e2e/__snapshots__/TransportMode.test.js.snap

@@ -2,11 +2,8 @@
 
 exports[`transportMode client custom client on browser client logs correctly 1`] = `
 Array [
-  "[HMR] Waiting for update signal from WDS...",
   "Hey.",
   "open",
-  "hot",
-  "[WDS] Hot Module Replacement enabled.",
   "liveReload",
   "[WDS] Live Reloading enabled.",
   "hash",
@@ -18,19 +15,15 @@ Array [
 
 exports[`transportMode client sockjs on browser client logs correctly 1`] = `
 Array [
-  "[HMR] Waiting for update signal from WDS...",
   "Hey.",
-  "[WDS] Hot Module Replacement enabled.",
   "[WDS] Live Reloading enabled.",
   "[WDS] Disconnected!",
 ]
 `;
 
 exports[`transportMode client ws on browser client logs correctly 1`] = `
 Array [
-  "[HMR] Waiting for update signal from WDS...",
   "Hey.",
-  "[WDS] Hot Module Replacement enabled.",
   "[WDS] Live Reloading enabled.",
   "[WDS] Disconnected!",
 ]