Skip to content

Commit 0de52b2

Browse files
committed
Enforce specific sockjs and sockjs-client version.
Ref #474
1 parent d21148b commit 0de52b2

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

lib/Server.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ var https = require("https");
1010
var httpProxyMiddleware = require("http-proxy-middleware");
1111
var serveIndex = require("serve-index");
1212
var historyApiFallback = require("connect-history-api-fallback");
13+
var pkg = require("../package.json");
1314

1415
function Server(compiler, options) {
1516
// Default options
@@ -307,6 +308,9 @@ Server.prototype.setContentHeaders = function(req, res, next) {
307308
Server.prototype.listen = function() {
308309
var returnValue = this.listeningApp.listen.apply(this.listeningApp, arguments);
309310
var sockServer = sockjs.createServer({
311+
// The SockJS server package uses a version of the client script
312+
// that doesn't match our version of the client script.
313+
sockjs_url: 'https://cdn.jsdelivr.net/sockjs/' + pkg.dependencies['sockjs-client'] + '/sockjs.min.js',
310314
// Limit useless logs
311315
log: function(severity, line) {
312316
if(severity === "error") {

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
"http-proxy-middleware": "~0.17.1",
1414
"opn": "4.0.2",
1515
"serve-index": "^1.7.2",
16-
"sockjs": "^0.3.15",
17-
"sockjs-client": "^1.0.3",
16+
"sockjs": "0.3.17",
17+
"sockjs-client": "1.1.1",
1818
"stream-cache": "~0.0.1",
1919
"strip-ansi": "^3.0.0",
2020
"supports-color": "^3.1.1",

0 commit comments

Comments
 (0)