Fix SSR test (#122)

wuct · SpaceK33z · commit b77ed0467799 · 2016-09-12T10:29:24.000+02:00
* Fix server side render test
* Enhance SSR section in README
diff --git a/README.md b/README.md
@@ -119,14 +119,40 @@ This part shows how you might interact with the middleware during runtime:
 ## Server-Side Rendering
 In order to develop a server-side rendering application, we need access to the [`stats`](https://github.com/webpack/docs/wiki/node.js-api#stats), which is generated with the latest build.
 
-In the server-side rendering mode, __webpack-dev-middleware__ sets the `stat` to `res.locals.webpackStats`, then call `next()` to trigger the next middleware, where we can render pages and response to clients. During the webpack building process, all requests will be pending until the build is finished and the `stat` is available.
+In the server-side rendering mode, __webpack-dev-middleware__ would sets the `stat` to `res.locals.webpackStats` before invoking the next middleware, where we can render pages and response to clients.
+
+Notice that requests for bundle files would still be responded by __webpack-dev-middleware__ and all requests will be pending until the building process is finished in the server-side rendering mode.
 
 ```JavaScript
 app.use(webpackMiddleware(compiler, { serverSideRender: true })
 
 // The following middleware would not be invoked until the latest build is finished.
 app.use((req, res) => {
-  const  assetsByChunkName = res.locals.webpackStats.toJson().assetsByChunkName
+  const assetsByChunkName = res.locals.webpackStats.toJson().assetsByChunkName
+
   // then use `assetsByChunkName` for server-sider rendering
+	// For example, if you have only one main chunk:
+
+	res.send(`
+<html>
+  <head>
+    <title>My App</title>
+		${
+			assetsByChunkName.main
+			.filter(path => path.endsWith('.css'))
+			.map(path => `<link rel="stylesheet" href="${path}" />`)
+		}
+  </head>
+  <body>
+    <div id="root"></div>
+		${
+			assetsByChunkName.main
+			.filter(path => path.endsWith('.js'))
+			.map(path => `<script src="${path}" />`)
+		}
+  </body>
+</html>		
+	`)
+
 })
 ```
diff --git a/test/Server.test.js b/test/Server.test.js
@@ -99,17 +99,16 @@ describe("Server", function() {
 			}));
 			app.use(function(req, res) {
 				locals = res.locals;
+				res.sendStatus(200);
 			});
 			listen = listenShorthand(done);
 		});
 		after(close);
 
 		it("request to bundle file", function(done) {
-			request(app).get("/bundle.js")
+			request(app).get("/foo/bar")
 			.expect(200, function() {
-				// TODO: I would expect `locals` to be set here.
-				// note that the liner underneath is purely to please the linter
-				should.strictEqual(locals, undefined);
+				should.exist(locals.webpackStats);
 				done();
 			});
 		});
