Skip to content

refactor: change if in else to else if #4470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

noritaka1166
Copy link
Contributor

What kind of change does this PR introduce?
refactoring

Did you add tests for your changes?
no

If relevant, did you update the documentation?
no

Summary
change if in else to else if for better readability

Does this PR introduce a breaking change?
no

Other information

@noritaka1166 noritaka1166 requested a review from a team as a code owner May 31, 2025 15:33
Copy link

codecov bot commented May 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.93%. Comparing base (31f634a) to head (97a0bc3).
Report is 241 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4470      +/-   ##
==========================================
- Coverage   90.18%   89.93%   -0.26%     
==========================================
  Files          22        9      -13     
  Lines        1702     1411     -291     
  Branches      491      460      -31     
==========================================
- Hits         1535     1269     -266     
+ Misses        167      142      -25     
Files with missing lines Coverage Δ
packages/configtest/src/index.ts 93.10% <100.00%> (-3.33%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5295c5f...97a0bc3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants