cli(node): add node-options handler #447
Conversation
|
Althought monitoring process did not showed anything problematic, i've seem some memory problems when tests runs... i'm having a look at that. |
bin/webpack.js
Outdated
| if (hasNodeFlags.length) { | ||
| require("./process-node-options")(process.argv); | ||
| return; | ||
| } |
There was a problem hiding this comment.
There is no need filter to check it.
const hasNodeFlags = process.argv.filter(arg => arg.includes("node."));
if (hasNodeFlags.length) {=>
const hasNodeFlags = process.argv.some(arg => arg.includes("node."));
if (hasNodeFlags) {
|
@playma256 any update on this? Is it ready for a review? |
|
Sorry @ev1stensberg , i had no time to look at this last week. By the way, do you have any ideas why the tests are consuming more memory and failing at appvoyer? The process management seems right, they aren't being kept alive when the children has terminated. To be able to implement that, the other approach i had implemented (with a different file invoking |
|
Try to commit a new commit with rebase against the next branch, should be better now |
.gitignore
Outdated
| @@ -30,3 +30,6 @@ lerna-debug.log | |||
|
|
|||
| # Yeoman file | |||
| .yo-rc.json | |||
|
|
|||
| # Yarn lock file | |||
| yarn.lock | |||
There was a problem hiding this comment.
This has been already merged in #455. Please rebase.
There was a problem hiding this comment.
I'll try to see what i can get with this... rebasing again...
There was a problem hiding this comment.
Yes, when i do git rebase upstream/next it says it has nothing to update. Neither a diff shows any difference. I've also copied next to my fork and it says the same.
There was a problem hiding this comment.
@ematipico @dhruvdutt reverted everything all the way from the rebase, where my branch started. Now git managed to do the rebase correctly and i only replayed all the commands...
|
Let's fetch and update the PR with he updated next branch and do this in a new PR |
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
Yes
Summary
Add possibility to pass node options to the cli.
Does this PR introduce a breaking change?
no