Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove obsolete snapshots for webpack@4 and webpack-dev-server@3 #3361

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Aug 6, 2022

What kind of change does this PR introduce?
refactor.

Did you add tests for your changes?
No.

If relevant, did you update the documentation?
No.

Summary

Remove obsolete snapshots for webpack@4 and webpack-dev-server@3.

Does this PR introduce a breaking change?
No

Other information

I feel we should keep our snapshot resolver as it is because in the future we may want to support multiple versions like webpack 5 and webpack 6, dev-server v4, and dev-server v5 again.

const snapshotExtension = `.snap.webpack${webpackVersion}`;
const snapshotExtensionForServe = `.snap.devServer${devServerVersion}.webpack${webpackVersion}`;

@snitin315 snitin315 requested a review from a team as a code owner August 6, 2022 12:11
@snitin315 snitin315 changed the title chore: remove obselete snapshots for webpack@4 and webpack-dev-server@3 chore: remove obsolete snapshots for webpack@4 and webpack-dev-server@3 Aug 6, 2022
@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #3361 (961a1b0) into next (98a6fd0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #3361   +/-   ##
=======================================
  Coverage   93.07%   93.07%           
=======================================
  Files          22       22           
  Lines        1617     1617           
  Branches      457      457           
=======================================
  Hits         1505     1505           
  Misses        112      112           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98a6fd0...961a1b0. Read the comment docs.

@alexander-akait alexander-akait merged commit b345a36 into next Aug 10, 2022
@alexander-akait alexander-akait deleted the refactor/rm-snapshots branch August 10, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants