-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove obsolete snapshots for webpack@4 and webpack-dev-server@3 #3361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
changed the title
chore: remove obselete snapshots for webpack@4 and webpack-dev-server@3
chore: remove obsolete snapshots for webpack@4 and webpack-dev-server@3
Aug 6, 2022
Codecov Report
@@ Coverage Diff @@
## next #3361 +/- ##
=======================================
Coverage 93.07% 93.07%
=======================================
Files 22 22
Lines 1617 1617
Branches 457 457
=======================================
Hits 1505 1505
Misses 112 112 Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Aug 10, 2022
snitin315
added a commit
that referenced
this pull request
Sep 10, 2022
snitin315
added a commit
that referenced
this pull request
Sep 17, 2022
snitin315
added a commit
that referenced
this pull request
Sep 24, 2022
snitin315
added a commit
that referenced
this pull request
Sep 24, 2022
snitin315
added a commit
that referenced
this pull request
Oct 8, 2022
snitin315
added a commit
that referenced
this pull request
Oct 22, 2022
snitin315
added a commit
that referenced
this pull request
Nov 6, 2022
snitin315
added a commit
that referenced
this pull request
Nov 8, 2022
alexander-akait
pushed a commit
that referenced
this pull request
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactor.
Did you add tests for your changes?
No.
If relevant, did you update the documentation?
No.
Summary
Remove obsolete snapshots for webpack@4 and webpack-dev-server@3.
Does this PR introduce a breaking change?
No
Other information
I feel we should keep our snapshot resolver as it is because in the future we may want to support multiple versions
like webpack 5 and webpack 6, dev-server v4, and dev-server v5
again.webpack-cli/scripts/snapshotResolver.js
Lines 8 to 9 in 85bdd85